You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Yates (Created) (JIRA)" <ji...@apache.org> on 2011/10/09 11:00:30 UTC
[jira] [Created] (HBASE-4559) Refactor TestAvroServer into an
integration test
Refactor TestAvroServer into an integration test
------------------------------------------------
Key: HBASE-4559
URL: https://issues.apache.org/jira/browse/HBASE-4559
Project: HBase
Issue Type: Improvement
Components: test
Reporter: Jesse Yates
TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "stack (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-4559:
----------------------------
Assignee: Jesse Yates
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "Jesse Yates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123655#comment-13123655 ]
Jesse Yates commented on HBASE-4559:
------------------------------------
Attached patch does not add any new unit test for avro server since everything in avro server seems to be just pass through functionality to the table admin. All the other functionality is covered already by TestAvroUtil.
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126199#comment-13126199 ]
Ted Yu commented on HBASE-4559:
-------------------------------
@Jesse, @Doug:
I think Jesse's comment @ 12/Oct/11 21:59 should be put into hbase book.
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "Jesse Yates (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-4559:
-------------------------------
Attachment: java_HBASE_4559.txt
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "Jesse Yates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126190#comment-13126190 ]
Jesse Yates commented on HBASE-4559:
------------------------------------
hmmm, its looking like 'tests' count as integration tests too. Checking on this...
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "Jesse Yates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126196#comment-13126196 ]
Jesse Yates commented on HBASE-4559:
------------------------------------
okay, here is the deal. To _just_ run integration tests, use:
{code}
mvn failsafe:integration-test
{code}
to run the integration tests. And then
{code}
mvn failsafe:verify
{code}
to verify the output results. That is when you will find out if the integration tests fail.
If you don't run the latter, then maven outputs success, even if you have integration test failures.
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126210#comment-13126210 ]
stack commented on HBASE-4559:
------------------------------
@Ted Agree. Let me do it on commit. Will commit in a while. Thanks Jesse.
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126127#comment-13126127 ]
stack commented on HBASE-4559:
------------------------------
Or is it just that verify will only run if skipTests is NOT set as per above?
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126126#comment-13126126 ]
stack commented on HBASE-4559:
------------------------------
This is a good test to move out since its being flakey in 0.92 (though the why needs fixing).
Patch looks good but when I did:
{code}
mvn -DskipTests verify
{code}
The new test did not run. Is this me?
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-4559:
-------------------------------
Resolution: Invalid
Status: Resolved (was: Patch Available)
Marking invalid. With Keywals' work on the different sized tests, we don't need to worry about this.
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4559) Refactor TestAvroServer into an
integration test
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4559:
-------------------------
Status: Patch Available (was: Open)
> Refactor TestAvroServer into an integration test
> ------------------------------------------------
>
> Key: HBASE-4559
> URL: https://issues.apache.org/jira/browse/HBASE-4559
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: java_HBASE_4559.txt
>
>
> TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.
> This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira