You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/05 12:39:56 UTC

[GitHub] [arrow-rs] alamb opened a new issue #1404: Triage remaining integration test failures with other Arrow implementations

alamb opened a new issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404


   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   It would be nice to have more complete integration coverage for the rust implementation, as well as more documentation and community knowledge about how to run them
   
   re #1398 
   
   The basic idea here is to triage remaining failures in the integration tests with the rust implementation and file tickets and/or fix them
   
   **Describe the solution you'd like**
   1. Setup the integration tests as described in https://github.com/apache/arrow-rs/pull/1403
   2. Verify that running `archery --debug integration --run-flight --with-cpp=true --with-rust=true`  passes without error
   
   Then, for each line like `.skip_category('Rust'),` in https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/datagen.py,:
   1. remove it from datagen.py
   2. Rerun `archery --debug integration --run-flight --with-cpp=true --with-rust=true`
   3. File figure out why it fails and fix it / file a ticket
   
   
   **Additional context**
   re #1398 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya commented on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya commented on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067596367


   I will work on above list one by one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet)
   * generate_interval_case(#1445)
   * generate_map_case
   * generate_non_canonical_map_case
   * generate_nested_large_offsets_case
   * generate_unions_case
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure, will put it later)
   * generate_interval_case (#1445)
   * generate_map_case (#1456)
   * generate_non_canonical_map_case
   * generate_nested_large_offsets_case
   * generate_unions_case
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure, will put it later)
   * generate_interval_case (#1445)
   * generate_map_case (#1456)
   * generate_non_canonical_map_case (blocked by generate_map_case)
   * generate_nested_large_offsets_case
   * generate_unions_case (I did some works locally but blocked by #67. Will spend some time on fix #67 first)
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure, will put it later)
   * generate_interval_case (#1445)
   * generate_map_case (#1456)
   * generate_non_canonical_map_case (blocked by generate_map_case)
   * generate_nested_large_offsets_case
   * generate_unions_case (I did some works locally but blocked by #67. Will spend some time on fix #67 first)
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure)
   * generate_interval_case(#1445)
   * generate_map_case
   * generate_non_canonical_map_case
   * generate_nested_large_offsets_case
   * generate_unions_case
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure, will put it later)
   * generate_interval_case (#1445)
   * generate_map_case (#1456)
   * generate_non_canonical_map_case
   * generate_nested_large_offsets_case
   * generate_unions_case (blocked by #67)
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure, will put it later)
   * generate_interval_case (#1445)
   * generate_map_case (#1456)
   * generate_non_canonical_map_case
   * generate_nested_large_offsets_case
   * generate_unions_case (I did some works locally but blocked by #67. Will spend some time on fix #67 first)
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure, will put it later)
   * generate_interval_case (#1445)
   * generate_map_case (#1456)
   * generate_non_canonical_map_case (#1475)
   * generate_nested_large_offsets_case
   * generate_unions_case (blocked by #67)
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya commented on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya commented on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   * generate_map_case
   * 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure)
   * generate_interval_case (#1445)
   * generate_map_case (#1456)
   * generate_non_canonical_map_case
   * generate_nested_large_offsets_case
   * generate_unions_case
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure, will put it later)
   * generate_interval_case (#1445)
   * generate_map_case (#1456)
   * generate_non_canonical_map_case (#1475)
   * generate_nested_large_offsets_case
   * generate_unions_case (I did some works locally but blocked by #67. Will spend some time on fix #67 first)
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on issue #1404:
URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726


   Working list:
   
   * generate_decimal128_case (fixed: #1439)
   * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few points I'm not sure, will put it later)
   * generate_interval_case (#1445)
   * generate_map_case (#1456)
   * generate_non_canonical_map_case (#1475)
   * generate_nested_large_offsets_case
   * generate_unions_case (blocked by #67)
   * generate_nested_dictionary_case
   * generate_extension_case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org