You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2022/07/05 12:22:12 UTC
[Impala-ASF-CR] IMPALA-11416: SlotRef::tuple is nullable uninitialised for struct children
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18702
Change subject: IMPALA-11416: SlotRef::tuple_is_nullable_ uninitialised for struct children
......................................................................
IMPALA-11416: SlotRef::tuple_is_nullable_ uninitialised for struct
children
In 'SlotRef::Init', 'tuple_is_nullable_' is only assigned a value if the
'SlotRef' is not within a struct:
```
if (!slot_desc_->parent()->isTupleOfStructSlot()) {
tuple_is_nullable_ = row_desc.TupleIsNullable(tuple_idx_);
}
```
Otherwise 'tuple_is_nullable_' remains uninitialised, leading to
undefined behaviour when it is read.
After this commit, 'tuple_is_nullable_' is set to false within structs.
Change-Id: I67517502ebc8f9bec52cb61d9922523cc4a56c4a
---
M be/src/exprs/slot-ref.cc
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/18702/1
--
To view, visit http://gerrit.cloudera.org:8080/18702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67517502ebc8f9bec52cb61d9922523cc4a56c4a
Gerrit-Change-Number: 18702
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
[Impala-ASF-CR] IMPALA-11416: SlotRef::tuple is nullable uninitialised for struct children
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18702 )
Change subject: IMPALA-11416: SlotRef::tuple_is_nullable_ uninitialised for struct children
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10923/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67517502ebc8f9bec52cb61d9922523cc4a56c4a
Gerrit-Change-Number: 18702
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 12:42:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11416: SlotRef::tuple is nullable uninitialised for struct children
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18702 )
Change subject: IMPALA-11416: SlotRef::tuple_is_nullable_ uninitialised for struct children
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8290/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67517502ebc8f9bec52cb61d9922523cc4a56c4a
Gerrit-Change-Number: 18702
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 12:22:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11416: SlotRef::tuple is nullable uninitialised for struct children
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18702 )
Change subject: IMPALA-11416: SlotRef::tuple_is_nullable_ uninitialised for struct children
......................................................................
IMPALA-11416: SlotRef::tuple_is_nullable_ uninitialised for struct
children
In 'SlotRef::Init', 'tuple_is_nullable_' is only assigned a value if the
'SlotRef' is not within a struct:
```
if (!slot_desc_->parent()->isTupleOfStructSlot()) {
tuple_is_nullable_ = row_desc.TupleIsNullable(tuple_idx_);
}
```
Otherwise 'tuple_is_nullable_' remains uninitialised, leading to
undefined behaviour when it is read.
After this commit, 'tuple_is_nullable_' is set to false within structs.
Change-Id: I67517502ebc8f9bec52cb61d9922523cc4a56c4a
Reviewed-on: http://gerrit.cloudera.org:8080/18702
Reviewed-by: Gabor Kaszab <ga...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/slot-ref.cc
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Gabor Kaszab: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I67517502ebc8f9bec52cb61d9922523cc4a56c4a
Gerrit-Change-Number: 18702
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11416: SlotRef::tuple is nullable uninitialised for struct children
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18702 )
Change subject: IMPALA-11416: SlotRef::tuple_is_nullable_ uninitialised for struct children
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67517502ebc8f9bec52cb61d9922523cc4a56c4a
Gerrit-Change-Number: 18702
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 17:10:34 +0000
Gerrit-HasComments: No