You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Drew Farris (JIRA)" <ji...@apache.org> on 2012/10/09 18:04:03 UTC
[jira] [Created] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Drew Farris created ACCUMULO-795:
------------------------------------
Summary: MockTable doesn't obey useVersions parameter
Key: ACCUMULO-795
URL: https://issues.apache.org/jira/browse/ACCUMULO-795
Project: Accumulo
Issue Type: Bug
Components: test
Affects Versions: 1.4.1, 1.5.0
Reporter: Drew Farris
Assignee: John Vines
Priority: Minor
The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Drew Farris updated ACCUMULO-795:
---------------------------------
Labels: hackathon (was: )
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Labels: hackathon
> Attachments: ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Turner updated ACCUMULO-795:
----------------------------------
Resolution: Fixed
Fix Version/s: 1.4.2
1.5.0
Assignee: Drew Farris (was: John Vines)
Status: Resolved (was: Patch Available)
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: Drew Farris
> Priority: Minor
> Labels: hackathon
> Fix For: 1.5.0, 1.4.2
>
> Attachments: ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Drew Farris updated ACCUMULO-795:
---------------------------------
Status: Patch Available (was: Open)
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.4.1, 1.5.0
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Attachments: ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Drew Farris updated ACCUMULO-795:
---------------------------------
Attachment: ACCUMULO-795.patch
Shuffled things around a bit -- {{IteratorUtil.generateInitialTableProperties()}} now takes a boolean argument {{limitVersion}} what will cause the Versioning Iterator to be added to the table if true.
This way, if we add additional default table properties, such as a Constraint that limits key size, we can add them here, and not worry about code calling {{generateInitialTableProperties}} or not.
The general contract would be that {{generateInitialTableProperties}} is always called when a new table is created regardless of whether it is mock or real.
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Attachments: ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Drew Farris updated ACCUMULO-795:
---------------------------------
Attachment: ACCUMULO-795.patch
Updated for latest revisions to 1.4.x
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Attachments: ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Drew Farris updated ACCUMULO-795:
---------------------------------
Attachment: ACCUMULO-795.patch
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Attachments: ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Drew Farris updated ACCUMULO-795:
---------------------------------
Attachment: ACCUMULO-795.patch
Updated unit test to validate absence/presence of VersioningIterator via insert and assert methods.
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Attachments: ACCUMULO-795.patch, ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-795) MockTable doesn't obey
useVersions parameter
Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472661#comment-13472661 ]
Keith Turner commented on ACCUMULO-795:
---------------------------------------
I think the test should that creates a table w/o the versioning iterator should also insert some data that would normally be suppressed by the versioning iterator. Do this before attaching the iterator.
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Attachments: ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Drew Farris updated ACCUMULO-795:
---------------------------------
Attachment: ACCUMULO-795.patch
Uhh, with this unit tests in the patch this time.
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Attachments: ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Drew Farris updated ACCUMULO-795:
---------------------------------
Attachment: (was: ACCUMULO-795.patch)
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Attachments: ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-795) MockTable doesn't obey useVersions
parameter
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Drew Farris updated ACCUMULO-795:
---------------------------------
Attachment: ACCUMULO-795.patch
One more time...
> MockTable doesn't obey useVersions parameter
> --------------------------------------------
>
> Key: ACCUMULO-795
> URL: https://issues.apache.org/jira/browse/ACCUMULO-795
> Project: Accumulo
> Issue Type: Bug
> Components: test
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Drew Farris
> Assignee: John Vines
> Priority: Minor
> Attachments: ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch, ACCUMULO-795.patch
>
>
> The constructor for {{MockTable}} will call {{IteratorUtil.generateInitialTableProperties()}}, and thus set a versioning iterator on itself regardless of whether the useVersion parameter is set to true or false.
> I believe {{MockTable}}'s constructor should call IteratorUtil.generateInitialTableProperties() only if useVersions is true, otherwise, it should populate {{settings}} with a new {{TreeMap}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira