You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Martin Kraemer <Ma...@mch.sni.de> on 1998/02/02 23:26:22 UTC
[BUG] with include paths and regex.h
I hope that I have re-created the current source tree from apache-cvs
mails and from what I saw in the webcvs-interface
With my current setup, a compiled server dies an immediate death because
the regex.h of the system does not match with the HS regex of the library
(the latter works with apache, the former doesn't).
So, my plea is:
* add an explicit -I .../regex/ to the Makefile.tmpl's or make
sure that the correct regex.h is used. (I added the -I to extra_includes)
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [BUG] with include paths and regex.h
Posted by Dean Gaudet <dg...@arctic.org>.
On Mon, 2 Feb 1998, Rodent of Unusual Size wrote:
> Martin Kraemer wrote:
> >
> > With my current setup, a compiled server dies an immediate death because
> > the regex.h of the system does not match with the HS regex of the library
> > (the latter works with apache, the former doesn't).
>
> So what's using the system's regex.h? The -I../include should result in
> all of the Apache stuff picking up the HS regex.h file. Since the
> Makefiles used to include an -I../regex, which is where regex.h used to
> live, I don't see how this could be happening - unless there's some
> stale .o files lying around.
He's not using hs regex. That's why it is broken. This is why I posted
about regex.h immediately after your commit... because your commit broke
systems not using hs regex.
> > So, my plea is:
> > * add an explicit -I .../regex/ to the Makefile.tmpl's or make
> > sure that the correct regex.h is used. (I added the -I to extra_includes)
>
> Someone (Jim?) suggested changing the name of the HS regex.h file to
> "hsregex.h", which sounds like a reasonable compromise - but I haven't
> looked into it. Since I did the .h movement I suppose it's incumbent
> upon me to fix up this residue..
To do this you'll have to add -DHSREGEX or something to the command line.
I actually don't have a preference for the solution to this one.
hsregex.h is fine. So is adding regex back to INCLUDES_AUTODEPTH. A
symlink is probably the wrong thing (due to win32)... and a copy is
definately the wrong thing (because someone may want to change regex.h).
Dean
Re: [BUG] with include paths and regex.h
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Martin Kraemer wrote:
>
> With my current setup, a compiled server dies an immediate death because
> the regex.h of the system does not match with the HS regex of the library
> (the latter works with apache, the former doesn't).
So what's using the system's regex.h? The -I../include should result in
all of the Apache stuff picking up the HS regex.h file. Since the
Makefiles used to include an -I../regex, which is where regex.h used to
live, I don't see how this could be happening - unless there's some
stale .o files lying around.
> So, my plea is:
> * add an explicit -I .../regex/ to the Makefile.tmpl's or make
> sure that the correct regex.h is used. (I added the -I to extra_includes)
Someone (Jim?) suggested changing the name of the HS regex.h file to
"hsregex.h", which sounds like a reasonable compromise - but I haven't
looked into it. Since I did the .h movement I suppose it's incumbent
upon me to fix up this residue..
#ken P-)}
Re: [BUG] with include paths and regex.h
Posted by Marc Slemko <ma...@worldgate.com>.
On Wed, 4 Feb 1998, Martin Kraemer wrote:
> On Wed, Feb 04, 1998 at 08:07:59AM -0700, Marc Slemko wrote:
> > > +0.7
> > >
> > > It leaves us with the dupes for points-in-time before the copying, but
> > > it preserves history. Actually, it would be best to remove all
> > > APACHE_XXXX tags in the copied (hsregex.h) version. That would cause cvs
> > > to skip it (I believe) for specific versions in the past: Then a
> >
> > But that removes a bunch of history... which isn't a good thing.
>
> IMHO the tags are part of the history of the _real_ file (i.e. the one
> in the old directory, or with the old file name). And the old file still
> has the tags, not?
But if I want to know what release was the first release with change x in
a particular file, I don't want to have to look at the file, figure out
that it used to live somewhere else, find that location, then check that
file.
Re: [BUG] with include paths and regex.h
Posted by Martin Kraemer <Ma...@mch.sni.de>.
On Wed, Feb 04, 1998 at 08:07:59AM -0700, Marc Slemko wrote:
> > +0.7
> >
> > It leaves us with the dupes for points-in-time before the copying, but
> > it preserves history. Actually, it would be best to remove all
> > APACHE_XXXX tags in the copied (hsregex.h) version. That would cause cvs
> > to skip it (I believe) for specific versions in the past: Then a
>
> But that removes a bunch of history... which isn't a good thing.
IMHO the tags are part of the history of the _real_ file (i.e. the one
in the old directory, or with the old file name). And the old file still
has the tags, not?
But, as I said, +0.7 to just cp the files.
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [BUG] with include paths and regex.h
Posted by Marc Slemko <ma...@worldgate.com>.
On Wed, 4 Feb 1998, Martin Kraemer wrote:
> On Tue, Feb 03, 1998 at 10:27:22PM -0500, Rodent of Unusual Size wrote:
> > Cool. Then I'll commit them as soon as someone assures me of the
> > right way to rename regex.h to hsregex.h. How about copying
> > regex.h,v to hsregex.h,v and then a cvs rm regex.h? Will that
> > be sufficient? (I'm still fried..)
>
> +0.7
>
> It leaves us with the dupes for points-in-time before the copying, but
> it preserves history. Actually, it would be best to remove all
> APACHE_XXXX tags in the copied (hsregex.h) version. That would cause cvs
> to skip it (I believe) for specific versions in the past: Then a
But that removes a bunch of history... which isn't a good thing.
Re: [BUG] with include paths and regex.h
Posted by Martin Kraemer <Ma...@mch.sni.de>.
On Tue, Feb 03, 1998 at 10:27:22PM -0500, Rodent of Unusual Size wrote:
> Cool. Then I'll commit them as soon as someone assures me of the
> right way to rename regex.h to hsregex.h. How about copying
> regex.h,v to hsregex.h,v and then a cvs rm regex.h? Will that
> be sufficient? (I'm still fried..)
+0.7
It leaves us with the dupes for points-in-time before the copying, but
it preserves history. Actually, it would be best to remove all
APACHE_XXXX tags in the copied (hsregex.h) version. That would cause cvs
to skip it (I believe) for specific versions in the past: Then a
cvs co -r APACHE_<tagname> apache-x.y
for a tag in the past would (I believe) only check out regex.h,
not hsregex.h.
Can anyone confirm/correct this?
Oh yeah, for past versions it could be useful to copy the
include/Attic/regex.c,v to regex/Attic/regex.c,v
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [BUG] with include paths and regex.h
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Dean Gaudet wrote:
>
> No your changes are required, we can't have our regex.h in the include
> path if we're using the system regex.
Cool. Then I'll commit them as soon as someone assures me of the
right way to rename regex.h to hsregex.h. How about copying
regex.h,v to hsregex.h,v and then a cvs rm regex.h? Will that
be sufficient? (I'm still fried..)
#ken P-)}
Re: [BUG] with include paths and regex.h
Posted by Dean Gaudet <dg...@arctic.org>.
No your changes are required, we can't have our regex.h in the include
path if we're using the system regex.
Dean
On Tue, 3 Feb 1998, Rodent of Unusual Size wrote:
> Martin Kraemer wrote:
> >
> > Sorry for having caused so much useless trouble. When I looked at the
> > wegcgi tree yesterday I thought that regex.h _hadn"t_ moved to include/
> > yet -- and exactly THAT was my problem.
> >
> > With this being fixed, the include path generated by Configure works for
> > me as well.
>
> Does this mean that everything is copacetic as it stands, and the rename
> to "hsregex.h" is unnecessary? In other words, can I undo the changes I
> have pending in my tree? :->
>
> #ken P-)}
>
Re: [BUG] with include paths and regex.h
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Martin Kraemer wrote:
>
> Sorry for having caused so much useless trouble. When I looked at the
> wegcgi tree yesterday I thought that regex.h _hadn"t_ moved to include/
> yet -- and exactly THAT was my problem.
>
> With this being fixed, the include path generated by Configure works for
> me as well.
Does this mean that everything is copacetic as it stands, and the rename
to "hsregex.h" is unnecessary? In other words, can I undo the changes I
have pending in my tree? :->
#ken P-)}
Re: [BUG] with include paths and regex.h
Posted by Martin Kraemer <Ma...@mch.sni.de>.
On Mon, Feb 02, 1998 at 11:26:22PM +0100, Martin Kraemer wrote:
> I hope that I have re-created the current source tree from apache-cvs
> mails and from what I saw in the webcvs-interface
Sorry for having caused so much useless trouble. When I looked at the
wegcgi tree yesterday I thought that regex.h _hadn"t_ moved to include/
yet -- and exactly THAT was my problem.
With this being fixed, the include path generated by Configure works for
me as well.
Again, sorry for having caused such a confusion (my CVS image is not on-line
but kept up-to-date by the apache-cvs mails).
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request