You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 09:29:12 UTC

[GitHub] [arrow-datafusion] domodwyer commented on issue #3140: approx_percentile_cont return wrong result when scan multi parquet files.

domodwyer commented on issue #3140:
URL: https://github.com/apache/arrow-datafusion/issues/3140#issuecomment-1217753548

   I wonder if this is something to do with serialisation/deserialisation of the `TDigest` state:
   
   https://github.com/apache/arrow-datafusion/blob/929eb6d860fb60ba994b24397ad3c3eb7d839cdf/datafusion/physical-expr/src/aggregate/tdigest.rs#L577-L670
   
   This is used when merging batches (`Accumulator::merge_batch`):
   
   https://github.com/apache/arrow-datafusion/blob/929eb6d860fb60ba994b24397ad3c3eb7d839cdf/datafusion/physical-expr/src/aggregate/approx_percentile_cont.rs#L410
   
   I know some changes were made to the `approx_percentile_cont` to support other parameters, perhaps some aren't carried over? I can take a look if this doesn't ring a bell with anyone :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org