[GitHub] [superset] hughhhh commented on a change in pull request #14829: feat(db-connection-ui): Big Query Add Database Form

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #14829:
URL: https://github.com/apache/superset/pull/14829#discussion_r645774655



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -259,6 +266,12 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
       }
     } else if (db) {
       // Create
+      if (update.encrypted_extra) {
+        // wrap encrypted_extra in credentials_info
+        update.encrypted_extra = JSON.stringify({
+          credentials_info: JSON.parse(update.encrypted_extra),

Review comment:
       This always breaks in the reducer since the user is typing, i rather have do the transform on save vs. having to put it in a try/catch




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org