[jira] [Work logged] (GOBBLIN-767) Support different time units in TimeBasedWriterPartitioner

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-767?focusedWorklogId=240328&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240328 ]

ASF GitHub Bot logged work on GOBBLIN-767:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/May/19 16:55
            Start Date: 10/May/19 16:55
    Worklog Time Spent: 10m 
      Work Description: zxcware commented on pull request #2630: [GOBBLIN-767] Support different time units in TimeBasedWriterPartitioner
URL: https://github.com/apache/incubator-gobblin/pull/2630
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title.
       - https://issues.apache.org/jira/browse/GOBBLIN-767
   
   
   ### Description
   - [x] Here are some details about my PR: 
   - Currently, `TimeBasedWriterPartitioner` assumes the timestamp value from a record is in millis. The task is to remove the assumption and support timestamp in different units, by default, in millis.
   
   ### Tests
   - [x] My PR adds the following unit tests:
   - `TimeBasedAvroWriterPartitionerTest.testWriter` tests writing with default unit and in seconds
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 240328)
            Time Spent: 10m
    Remaining Estimate: 0h

> Support different time units in TimeBasedWriterPartitioner
> ----------------------------------------------------------
>
>                 Key: GOBBLIN-767
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-767
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Zhixiong Chen
>            Assignee: Zhixiong Chen
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, `TimeBasedWriterPartitioner` assumes the timestamp value from a record is in millis. The task is to remove the assumption and support timestamp in different units, by default, in millis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)