You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Henri Yandell (JIRA)" <ji...@apache.org> on 2006/12/22 20:57:21 UTC

[jira] Created: (LANG-303) FastDateFormat.mRules is not transient or serializable

FastDateFormat.mRules is not transient or serializable
------------------------------------------------------

                 Key: LANG-303
                 URL: http://issues.apache.org/jira/browse/LANG-303
             Project: Commons Lang
          Issue Type: Bug
    Affects Versions: 2.2
            Reporter: Henri Yandell
             Fix For: 2.3


Reported by FindBugs.

Either we need to make the Rule interface Serializable, or make mRules transient and add deserializing code to kick off init().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (LANG-303) FastDateFormat.mRules is not transient or serializable

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/LANG-303?page=comments#action_12460929 ] 
            
Henri Yandell commented on LANG-303:
------------------------------------

svn ci -m "Improved #LANG-303 test to prove the formatting works on each side of the serializing" src/

Sending        src/test/org/apache/commons/lang/time/FastDateFormatTest.java
Transmitting file data .
Committed revision 490388.

> FastDateFormat.mRules is not transient or serializable
> ------------------------------------------------------
>
>                 Key: LANG-303
>                 URL: http://issues.apache.org/jira/browse/LANG-303
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Henri Yandell
>             Fix For: 2.3
>
>
> Reported by FindBugs.
> Either we need to make the Rule interface Serializable, or make mRules transient and add deserializing code to kick off init().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Closed: (LANG-303) FastDateFormat.mRules is not transient or serializable

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LANG-303?page=all ]

Henri Yandell closed LANG-303.
------------------------------

    Resolution: Fixed

svn ci -m "Applying test for #LANG-303, and a fix. " src/
Sending        src/java/org/apache/commons/lang/time/FastDateFormat.java
Sending        src/test/org/apache/commons/lang/time/FastDateFormatTest.java
Transmitting file data ..
Committed revision 490387.

mRules and mMaxLengthEstimate have been made transient as the init() method sets both of them up.

The deserialize method is:

+    // Serializing
+    //-----------------------------------------------------------------------
+    private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
+        in.defaultReadObject();
+        init();
+    }



> FastDateFormat.mRules is not transient or serializable
> ------------------------------------------------------
>
>                 Key: LANG-303
>                 URL: http://issues.apache.org/jira/browse/LANG-303
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Henri Yandell
>             Fix For: 2.3
>
>
> Reported by FindBugs.
> Either we need to make the Rule interface Serializable, or make mRules transient and add deserializing code to kick off init().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (LANG-303) FastDateFormat.mRules is not transient or serializable

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/LANG-303?page=comments#action_12460908 ] 
            
Henri Yandell commented on LANG-303:
------------------------------------

The latter seems to make the most sense - the Rule objects are a tokenized version of the mPattern String, and that is going to be happily serialized.

(I've no clue why java.text.Format is Serializable anyway)

> FastDateFormat.mRules is not transient or serializable
> ------------------------------------------------------
>
>                 Key: LANG-303
>                 URL: http://issues.apache.org/jira/browse/LANG-303
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Henri Yandell
>             Fix For: 2.3
>
>
> Reported by FindBugs.
> Either we need to make the Rule interface Serializable, or make mRules transient and add deserializing code to kick off init().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org