You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "Dave Brosius (JIRA)" <xe...@xml.apache.org> on 2006/09/09 18:46:22 UTC

[jira] Created: (XERCESJ-1185) [PATCH] add code to guard against npe

[PATCH] add code to guard against npe
-------------------------------------

                 Key: XERCESJ-1185
                 URL: http://issues.apache.org/jira/browse/XERCESJ-1185
             Project: Xerces2-J
          Issue Type: Bug
          Components: DOM (HTML)
    Affects Versions: 2.8.1
            Reporter: Dave Brosius
            Priority: Minor
         Attachments: guard_against_npe.diff

code erroneously gets list item 0 without checking size, then checks and gets element 0 if it exists. Remove the first unsafe operation

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Updated: (XERCESJ-1185) [PATCH] add code to guard against npe

Posted by "Dave Brosius (JIRA)" <xe...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XERCESJ-1185?page=all ]

Dave Brosius updated XERCESJ-1185:
----------------------------------

    Attachment: guard_against_npe.diff

> [PATCH] add code to guard against npe
> -------------------------------------
>
>                 Key: XERCESJ-1185
>                 URL: http://issues.apache.org/jira/browse/XERCESJ-1185
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: DOM (HTML)
>    Affects Versions: 2.8.1
>            Reporter: Dave Brosius
>            Priority: Minor
>         Attachments: guard_against_npe.diff
>
>
> code erroneously gets list item 0 without checking size, then checks and gets element 0 if it exists. Remove the first unsafe operation

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Resolved: (XERCESJ-1185) [PATCH] add code to guard against npe

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XERCESJ-1185?page=all ]

Michael Glavassevich resolved XERCESJ-1185.
-------------------------------------------

    Fix Version/s: 2.8.1
       Resolution: Fixed

Thanks Dave. I've committed your patch to SVN.  That line of code was redundant though you wouldn't get an NPE.  NodeList.item() returns null if the index passed to it isn't valid.

> [PATCH] add code to guard against npe
> -------------------------------------
>
>                 Key: XERCESJ-1185
>                 URL: http://issues.apache.org/jira/browse/XERCESJ-1185
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: DOM (HTML)
>    Affects Versions: 2.8.0
>            Reporter: Dave Brosius
>         Assigned To: Michael Glavassevich
>            Priority: Minor
>             Fix For: 2.8.1
>
>         Attachments: guard_against_npe.diff
>
>
> code erroneously gets list item 0 without checking size, then checks and gets element 0 if it exists. Remove the first unsafe operation

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Updated: (XERCESJ-1185) [PATCH] add code to guard against npe

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XERCESJ-1185?page=all ]

Michael Glavassevich updated XERCESJ-1185:
------------------------------------------

    Affects Version/s: 2.8.0
                           (was: 2.8.1)

> [PATCH] add code to guard against npe
> -------------------------------------
>
>                 Key: XERCESJ-1185
>                 URL: http://issues.apache.org/jira/browse/XERCESJ-1185
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: DOM (HTML)
>    Affects Versions: 2.8.0
>            Reporter: Dave Brosius
>            Priority: Minor
>         Attachments: guard_against_npe.diff
>
>
> code erroneously gets list item 0 without checking size, then checks and gets element 0 if it exists. Remove the first unsafe operation

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Assigned: (XERCESJ-1185) [PATCH] add code to guard against npe

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XERCESJ-1185?page=all ]

Michael Glavassevich reassigned XERCESJ-1185:
---------------------------------------------

    Assignee: Michael Glavassevich

> [PATCH] add code to guard against npe
> -------------------------------------
>
>                 Key: XERCESJ-1185
>                 URL: http://issues.apache.org/jira/browse/XERCESJ-1185
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: DOM (HTML)
>    Affects Versions: 2.8.0
>            Reporter: Dave Brosius
>         Assigned To: Michael Glavassevich
>            Priority: Minor
>         Attachments: guard_against_npe.diff
>
>
> code erroneously gets list item 0 without checking size, then checks and gets element 0 if it exists. Remove the first unsafe operation

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org