You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/03/11 22:18:08 UTC
Review Request 19068: Fix for build failure of Python-Egg on OSX clang 3.4
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19068/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Bugs: MESOS-1079
https://issues.apache.org/jira/browse/MESOS-1079
Repository: mesos-git
Description
-------
Workaround for incompatibility of clang 3.4 with build settings of Apple's Python distribution. Adds PYTHON_CFLAGS and PYTHON_CPPFLAGS to configuration phase. Those variables are pre-populated by the contents of CFLAGS and CPPFLAGS. When clang is used for the compilation, the -Qunused-arguments override is added to both variables to deescalate possible errors caused by unknown commandline flags towards warnings, thus allowing to build our Python egg with clang 3.4 (Xcode 5.1) and Apple's default Python.
Diffs
-----
configure.ac 390f11b
src/Makefile.am 384b312
Diff: https://reviews.apache.org/r/19068/diff/
Testing
-------
make check (clang and gcc, osx and linux)
Thanks,
Till Toenshoff
Re: Review Request 19068: Fix for build failure of Python-Egg on OSX clang
3.4
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19068/
-----------------------------------------------------------
(Updated March 14, 2014, 11:26 a.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Assigning myself as shepherd
-- Niklas
Bugs: MESOS-1079
https://issues.apache.org/jira/browse/MESOS-1079
Repository: mesos-git
Description
-------
Workaround for incompatibility of clang 3.4 with build settings of Apple's Python distribution. Adds PYTHON_CFLAGS and PYTHON_CPPFLAGS to configuration phase. Those variables are pre-populated by the contents of CFLAGS and CPPFLAGS. When clang is used for the compilation, the -Qunused-arguments override is added to both variables to deescalate possible errors caused by unknown commandline flags towards warnings, thus allowing to build our Python egg with clang 3.4 (Xcode 5.1) and Apple's default Python.
Diffs
-----
configure.ac 390f11b
src/Makefile.am 384b312
Diff: https://reviews.apache.org/r/19068/diff/
Testing
-------
make check (clang and gcc, osx and linux)
Thanks,
Till Toenshoff
Re: Review Request 19068: Fix for build failure of Python-Egg on OSX clang
3.4
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19068/#review36847
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19068]
All tests passed.
- Mesos ReviewBot
On March 11, 2014, 9:38 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19068/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 9:38 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1079
> https://issues.apache.org/jira/browse/MESOS-1079
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Workaround for incompatibility of clang 3.4 with build settings of Apple's Python distribution. Adds PYTHON_CFLAGS and PYTHON_CPPFLAGS to configuration phase. Those variables are pre-populated by the contents of CFLAGS and CPPFLAGS. When clang is used for the compilation, the -Qunused-arguments override is added to both variables to deescalate possible errors caused by unknown commandline flags towards warnings, thus allowing to build our Python egg with clang 3.4 (Xcode 5.1) and Apple's default Python.
>
>
> Diffs
> -----
>
> configure.ac 390f11b
> src/Makefile.am 384b312
>
> Diff: https://reviews.apache.org/r/19068/diff/
>
>
> Testing
> -------
>
> make check (clang and gcc, osx and linux)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 19068: Fix for build failure of Python-Egg on OSX clang
3.4
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19068/#review37146
-----------------------------------------------------------
Ship it!
Thanks Till! Really like to see this land soon
- Niklas Nielsen
On March 11, 2014, 2:38 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19068/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 2:38 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-1079
> https://issues.apache.org/jira/browse/MESOS-1079
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Workaround for incompatibility of clang 3.4 with build settings of Apple's Python distribution. Adds PYTHON_CFLAGS and PYTHON_CPPFLAGS to configuration phase. Those variables are pre-populated by the contents of CFLAGS and CPPFLAGS. When clang is used for the compilation, the -Qunused-arguments override is added to both variables to deescalate possible errors caused by unknown commandline flags towards warnings, thus allowing to build our Python egg with clang 3.4 (Xcode 5.1) and Apple's default Python.
>
>
> Diffs
> -----
>
> configure.ac 390f11b
> src/Makefile.am 384b312
>
> Diff: https://reviews.apache.org/r/19068/diff/
>
>
> Testing
> -------
>
> make check (clang and gcc, osx and linux)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 19068: Fix for build failure of Python-Egg on OSX clang
3.4
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19068/
-----------------------------------------------------------
(Updated March 11, 2014, 9:38 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Changes
-------
Alignment fix, it just looked weird.
Bugs: MESOS-1079
https://issues.apache.org/jira/browse/MESOS-1079
Repository: mesos-git
Description
-------
Workaround for incompatibility of clang 3.4 with build settings of Apple's Python distribution. Adds PYTHON_CFLAGS and PYTHON_CPPFLAGS to configuration phase. Those variables are pre-populated by the contents of CFLAGS and CPPFLAGS. When clang is used for the compilation, the -Qunused-arguments override is added to both variables to deescalate possible errors caused by unknown commandline flags towards warnings, thus allowing to build our Python egg with clang 3.4 (Xcode 5.1) and Apple's default Python.
Diffs (updated)
-----
configure.ac 390f11b
src/Makefile.am 384b312
Diff: https://reviews.apache.org/r/19068/diff/
Testing
-------
make check (clang and gcc, osx and linux)
Thanks,
Till Toenshoff