You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/11/25 23:38:49 UTC
[Bug 57261] New: Align /vminfo and /threaddump with other Manager
commands and document them
https://issues.apache.org/bugzilla/show_bug.cgi?id=57261
Bug ID: 57261
Summary: Align /vminfo and /threaddump with other Manager
commands and document them
Product: Tomcat 8
Version: 8.0.15
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Manager
Assignee: dev@tomcat.apache.org
Reporter: knst.kolinko@gmail.com
ManagerServlet supports the following commands that are not yet documented:
http://localhost:8080/manager/text/vminfo
http://localhost:8080/manager/text/threaddump
For reference see r1476960 (in 8.0.0) and r1578256 (in 8.0.4).
TODO:
1. It is documented that all Manager commands have output that starts with
"OK".
These commands do not have an "OK" line, but start their output with a date. It
is wrong and has to be fixed.
This includes the need to fix VminfoTask and ThreaddumpTask Ant tasks
(r1578256).
2. Document them in manager-howto.html
3. Maybe mention them in Javadoc for ManagerServlet class, like other commands
are listed there.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57261] Align /vminfo and /threaddump with other Manager
commands and document them
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57261
--- Comment #4 from Oleg Trokhov <ot...@minsk.ximxim.com> ---
I found this classes, they have only these code:
public void execute() throws BuildException {
super.execute();
execute("/threaddump");
}
Output from manager commands doesn't broken, all work fine. Or I misunderstood
something?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57261] Align /vminfo and /threaddump with other Manager
commands and document them
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57261
Konstantin Kolinko <kn...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Konstantin Kolinko <kn...@gmail.com> ---
Fixed in trunk and 8.0.x (r1643737) and will be in 8.0.16 onwards.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57261] Align /vminfo and /threaddump with other Manager
commands and document them
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57261
Oleg Trokhov <ot...@minsk.ximxim.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #2 from Oleg Trokhov <ot...@minsk.ximxim.com> ---
1. I added "OK" and some short description to responces, but what you mean
about "need to fix VminfoTask and ThreaddumpTask Ant tasks"?
2. Added
3. This comments alredy exist in ManagerServlet class
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57261] Align /vminfo and /threaddump with other Manager
commands and document them
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57261
--- Comment #7 from Konstantin Kolinko <kn...@gmail.com> ---
I ported /vminfo and /threaddump commands to Tomcat 7 (r1643750, r1643754).
They will be in 7.0.58 onwards.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57261] Align /vminfo and /threaddump with other Manager
commands and document them
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57261
--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> ---
(In reply to Oleg Trokhov from comment #2)
There exist org.apache.catalina.ant.VminfoTask and ThreaddumpTask classes that
are used as tasks in Ant. They call those manager commands via HTTP and parse
their response. They should not stop working with the change of the output
format.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57261] Align /vminfo and /threaddump with other Manager
commands and document them
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57261
--- Comment #1 from Oleg Trokhov <ot...@minsk.ximxim.com> ---
Created attachment 32231
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32231&action=edit
Resolve 1 and 2 task item
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57261] Align /vminfo and /threaddump with other Manager
commands and document them
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57261
--- Comment #5 from Konstantin Kolinko <kn...@gmail.com> ---
(In reply to Oleg Trokhov from comment #4)
OK. Thank you.
Before looking at the source code I thought that there was some built-in change
in behaviour. Actually there is an explicit configuration setting available
(ignoreResponseConstraint attribute on AbstractCatalinaTask), that allows to
turn off parsing of the first line of the response.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org