[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18958: [chore](build) Use include-what-you-use to optimize includes (PART III)

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #18958:
URL: https://github.com/apache/doris/pull/18958#discussion_r1174542858


##########
be/test/testutil/desc_tbl_builder.h:
##########
@@ -18,13 +18,17 @@
 #ifndef DORIS_BE_SRC_TESTUTIL_DESC_TBL_BUILDER_H
 #define DORIS_BE_SRC_TESTUTIL_DESC_TBL_BUILDER_H

Review Comment:
   warning: macro is not used [clang-diagnostic-unused-macros]
   ```cpp
   #define DORIS_BE_SRC_TESTUTIL_DESC_TBL_BUILDER_H
           ^
   ```
   



##########
be/test/runtime/test_env.h:
##########
@@ -18,10 +18,16 @@
 #ifndef DORIS_BE_TEST_QUERY_RUNTIME_TEST_ENV_H
 #define DORIS_BE_TEST_QUERY_RUNTIME_TEST_ENV_H

Review Comment:
   warning: macro is not used [clang-diagnostic-unused-macros]
   ```cpp
   #define DORIS_BE_TEST_QUERY_RUNTIME_TEST_ENV_H
           ^
   ```
   



##########
be/test/testutil/test_util.h:
##########
@@ -17,14 +17,11 @@
 
 #pragma once
 
-#include <chrono>
 #include <cstdlib>
-#include <random>
 #include <string>
 
-#include "olap/tablet_schema.h"
-
 namespace doris {
+enum class FieldType;
 
 #define LOOP_LESS_OR_MORE(less, more) (AllowSlowTests() ? more : less)

Review Comment:
   warning: macro is not used [clang-diagnostic-unused-macros]
   ```cpp
   #define LOOP_LESS_OR_MORE(less, more) (AllowSlowTests() ? more : less)
           ^
   ```
   



##########
be/src/gutil/atomicops-internals-x86.h:
##########
@@ -26,8 +26,9 @@
 
 #pragma once
 
-#include <common/logging.h>
+#include "common/logging.h"
 #include <stdint.h>
+#include <ostream>
 
 #define BASE_HAS_ATOMIC64 1 // Use only in tests and base/atomic*

Review Comment:
   warning: macro is not used [clang-diagnostic-unused-macros]
   ```cpp
   #define BASE_HAS_ATOMIC64 1 // Use only in tests and base/atomic*
           ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org