You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/27 07:35:07 UTC
[GitHub] [spark] zhengruifeng commented on issue #27978: [SPARK-31127][ML]
Implement abstract Selector
zhengruifeng commented on issue #27978: [SPARK-31127][ML] Implement abstract Selector
URL: https://github.com/apache/spark/pull/27978#issuecomment-604857001
It seems that you still need to override setters and getters in subclasses, like
```scala
override def setNumTopFeatures(value: Int): this.type = super.setNumTopFeatures(value)
```
It seems that the main benefit is to avoid copying the transfrom part in subclasses, at the cost of adding several abstract classes. So what about just resuing the transfrom function among selection models?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org