[GitHub] [hudi] cuibo01 commented on a diff in pull request #5528: [HUDI-3336][HUDI-FLINK]Support custom hadoop config for flink

[GitBox <gi...@apache.org>]

cuibo01 commented on code in PR #5528:
URL: https://github.com/apache/hudi/pull/5528#discussion_r868699640


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -746,16 +762,18 @@ public static Configuration flatOptions(Configuration conf) {
           : key;
       propsMap.put(subKey, value);
     });
-    return fromMap(propsMap);
+    return Configuration.fromMap(propsMap);
   }
 
-  private static boolean hasPropertyOptions(Map<String, String> options) {
-    return options.keySet().stream().anyMatch(k -> k.startsWith(PROPERTIES_PREFIX));
+  private static boolean hasPropertyOptions(Map<String, String> options, String prefix) {
+    return options.keySet().stream().anyMatch(k -> k.startsWith(prefix));
   }
 
   /**
    * Creates a new configuration that is initialized with the options of the given map.
+   * @deprecated Use {@link Configuration#fromMap(Map)} instead.
    */
+  @Deprecated
   public static Configuration fromMap(Map<String, String> map) {

Review Comment:
   update



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org