You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/13 14:43:10 UTC
[GitHub] [kafka-site] divijvaidya opened a new pull request, #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
divijvaidya opened a new pull request, #421:
URL: https://github.com/apache/kafka-site/pull/421
**Why**
As per the [Apache branching policy](https://www.apache.org/foundation/marks/pmcs#navigation), every project website's main navigation system must feature certain text links back to key pages on the main www.apache.org website.
**What**
Added a new item 'Apache Software' to the top nav bar which includes the required links including Privacy Policy requirement outlined in https://issues.apache.org/jira/browse/KAFKA-13868
**Tested**
Tested the change by running website locally. The new nav bar looks as follows:
<img width="1549" alt="Screenshot 2022-07-13 at 16 42 25" src="https://user-images.githubusercontent.com/71267/178761918-cf18f304-c13d-4a94-b567-1a6329bad4ee.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] mimaison commented on pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
mimaison commented on PR #421:
URL: https://github.com/apache/kafka-site/pull/421#issuecomment-1187033048
Thanks @divijvaidya for looking into this as the deadline is approaching quickly now!
I'm not sure we need a full Apache menu. Have you considered just adding a Privacy Policy link in the footer. For example a bit like it's done on https://flink.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] tombentley commented on a diff in pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
tombentley commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923497051
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item" role="menuitem">
+ <a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu" aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/" target="_blank">
+ Apache Homepage
Review Comment:
Yeah, that's what I was suggesting, if it's acceptable to others. @mimaison, @ijuma please chime in if you disagree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] mimaison merged pull request #421: KAFKA-13868: Add ASF links to the footer including privacy policy
Posted by GitBox <gi...@apache.org>.
mimaison merged PR #421:
URL: https://github.com/apache/kafka-site/pull/421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] showuon commented on a diff in pull request #421: KAFKA-13868: Add ASF links to the footer including privacy policy
Posted by GitBox <gi...@apache.org>.
showuon commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r924146761
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item" role="menuitem">
+ <a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu" aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/" target="_blank">
+ Apache Homepage
Review Comment:
Agree with @tombentley 's suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923575015
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item" role="menuitem">
+ <a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu" aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/" target="_blank">
+ Apache Homepage
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/licenses/">
+ License
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/events/current-event">
+ Events
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/foundation/sponsorship.html" target="_blank">
+ Sponsorship
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/foundation/thanks.html">
+ Sponsors
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/security/">
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] mimaison commented on a diff in pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
mimaison commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923435396
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item" role="menuitem">
+ <a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+ Apache Software
Review Comment:
Should we use `Apache Software Foundation` or `Apache` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923468457
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item" role="menuitem">
+ <a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu" aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/" target="_blank">
+ Apache Homepage
Review Comment:
That is fair.
Just to re-iterate so that we are on the same page, we want to remove the "Apache Software" section from the nav bar and instead add it to the footer of the homepage towards the bottom. That section will contain the necessary hyperlinks that are required by ASF.
I am a bit rusty with my front-end skills but let me try to see what I can do here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923575649
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item" role="menuitem">
+ <a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+ Apache Software
Review Comment:
This comment is not valid any more. I moved the links to footer which already have a link to Apache homepage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] divijvaidya commented on pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #421:
URL: https://github.com/apache/kafka-site/pull/421#issuecomment-1183316551
@mimaison please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #421: KAFKA-13868: Add ASF links to the footer including privacy policy
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923583008
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item" role="menuitem">
+ <a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu" aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/" target="_blank">
+ Apache Homepage
Review Comment:
I have made the changes as suggested by @tombentley and added the ASF links to the footer. Note that there are some projects which choose to keep a separate section in nav bar for ASF links (e.g. [Spark](https://spark.apache.org/), [TinkerPop](https://tinkerpop.apache.org/)) while some other choose to keep it in the footer (e.g. [superset](https://superset.apache.org/), [Hudi](https://hudi.apache.org/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] tombentley commented on a diff in pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
tombentley commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923438915
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item" role="menuitem">
+ <a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu" aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/" target="_blank">
+ Apache Homepage
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/licenses/">
+ License
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/events/current-event">
+ Events
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/foundation/sponsorship.html" target="_blank">
+ Sponsorship
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/foundation/thanks.html">
+ Sponsors
+ </a>
+ </li>
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/security/">
Review Comment:
The Apache policy allows to link to a project specific page, and we already have this at https://kafka.apache.org/project-security. I think using that would be better that linking to the overarching Apache security page.
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item" role="menuitem">
+ <a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu" aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li class="top-nav-menu-item" role="menuitem">
+ <a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/" target="_blank">
+ Apache Homepage
Review Comment:
The policy says
> This may either be a featured link in your main navigation system or a text link in your Main homepage text. A best practice is to include a short sentence or paragraph on the homepage noting that this project is an Apache project, and is part of a larger community of developers and users.
So making the 'Apache' part of the homepage a link, and including this information further down (after the "Trust and Ease of Use" section) should also be acceptable, and indeed closer to the best practice.
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] divijvaidya commented on pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #421:
URL: https://github.com/apache/kafka-site/pull/421#issuecomment-1187036010
@mimaison thank you for your review.
> I'm not sure we need a full Apache menu
I think we do indeed need the full Apache menu. Please refer to [Apache branding policy](https://www.apache.org/foundation/marks/pmcs#navigation). Quoting a section from there:
```
Whatever main navigation system your project website uses, it must feature certain text links back to key pages on the main www.apache.org website. These links can appear in whatever main navigation system your site uses on all top level pages for the project or subproject.
"License" should link to: www.apache.org/licenses/
"Sponsorship" or "Donate" should link to: www.apache.org/foundation/sponsorship.html
"Sponsors", "Thanks" or "Thanks to our Sponsors" should link to: www.apache.org/foundation/thanks.html
"Security" should link to either to a project-specific page detailing how users may securely report potential vulnerabilities, or to the main [www.apache.org/security/](https://www.apache.org/security/) page
"Privacy" should link to: privacy.apache.org/policies/privacy-policy-public.html
All projects must feature some prominent link back to the main ASF homepage at www.apache.org. This may either be a featured link in your main navigation system or a text link in your Main homepage text. A best practice is to include a short sentence or paragraph on the homepage noting that this project is an Apache project, and is part of a larger community of developers and users.
```
Please let me know if I am missing something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] mimaison commented on pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy
Posted by GitBox <gi...@apache.org>.
mimaison commented on PR #421:
URL: https://github.com/apache/kafka-site/pull/421#issuecomment-1187557669
You are right, these links should be included. Thanks for following up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org