[GitHub] [arrow] lidavidm commented on a diff in pull request #13455: ARROW-16864: [Python] Allow omitting S3 external_id and session_name with role_arn

[GitBox <gi...@apache.org>]

lidavidm commented on code in PR #13455:
URL: https://github.com/apache/arrow/pull/13455#discussion_r908787463


##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -381,13 +381,21 @@ Result<S3Options> S3Options::FromUri(const std::string& uri_string,
 }
 
 bool S3Options::Equals(const S3Options& other) const {
+  const int64_t default_metadata_size = default_metadata ? default_metadata->size() : 0;
+  const bool default_metadata_equals =
+      default_metadata_size

Review Comment:
   nit: is it possible to have a non-nullptr `default_metadata` that is of size 0? Should this check instead be `default_metadata`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org