You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:03:57 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #4729: API: access to build properties of gradle script [2/3]
sdedic opened a new pull request, #4729:
URL: https://github.com/apache/netbeans/pull/4729
Important Note: this is 2nd from 3 dependent PRs, depends on #4726. For review purposes, the PR targets a feature branch in the shared repository, that will be deleted after the related PRs are merged - it allows to inspect/review changes before the base PR (#4726) is merged. The time is becoming a little issue for me :)
Traditionally a module that need information from the gradle build system other than collected by the gradle core and exposed would have to add its 'agent' into `netbeans-gradle-tooling` subproject, then implement `ProjectInfoExtractor`.
This PR allows NetBeans modules to inspect gradle build properties. Clients may even adapt to changes by listening on Gradle project's reload event. The Gradle core module loads a lot more properties from the project model in Gradle process and marshall the information to the IDE. The introduced API allows to inspect individual properties, enumerate lists or access map keys.
NetBeans modules do not need to implement a tooling agent that their `ProjectInfoExtractor` interfaces with, and in fact they do not need the Extractor at all - unless they need to expose a service in projectLookup. I would consider the exact format exchanged between NetBeans gradle tooling (gradle) plugin and the `BuildPropertiesSupport` implementation private: although the data can be read by `ProjectInfoExtractor`s, the intention is to hide the exact wire format behind the API.
The last PR in this group adaps `java.gradle` and `micronaut` modules to declare their file products (artifacts) based on values inspected from the gradle build script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4729: API: access to build properties of gradle script [2/3]
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4729:
URL: https://github.com/apache/netbeans/pull/4729#issuecomment-1265473283
Note: there was a concern that introspecting the buildscript will activate potentially harmful/long-running user code in Tasks. The fact is that data collector for `Navigator` window contents, that displays tasks performs task instantiation already. So tasks area created (and user code is potentially) for som years already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists