You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/03/06 06:46:14 UTC
[GitHub] vongosling commented on a change in pull request #205: [ROCKETMQ-319] improve broker register performance and reduce memory usage
vongosling commented on a change in pull request #205: [ROCKETMQ-319] improve broker register performance and reduce memory usage
URL: https://github.com/apache/rocketmq/pull/205#discussion_r172422263
##########
File path: broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java
##########
@@ -231,6 +259,72 @@ public void unregisterBroker(
throw new MQBrokerException(response.getCode(), response.getRemark());
}
+ public List<Boolean> needRegister(
+ final String clusterName,
+ final String brokerAddr,
+ final String brokerName,
+ final long brokerId,
+ final TopicConfigSerializeWrapper topicConfigWrapper,
+ final int timeoutMills) {
+ final List<Boolean> changedList = new CopyOnWriteArrayList<>();
+ List<String> nameServerAddressList = this.remotingClient.getNameServerAddressList();
+ if (nameServerAddressList != null && nameServerAddressList.size() > 0) {
+ final CountDownLatch countDownLatch = new CountDownLatch(nameServerAddressList.size());
+ for (final String namesrvAddr : nameServerAddressList) {
+ brokerOuterExecutor.execute(new Runnable() {
+ @Override
+ public void run() {
+ try {
+ QueryDataVersionRequestHeader requestHeader = new QueryDataVersionRequestHeader();
+ requestHeader.setBrokerAddr(brokerAddr);
+ requestHeader.setBrokerId(brokerId);
+ requestHeader.setBrokerName(brokerName);
+ requestHeader.setClusterName(clusterName);
+ RemotingCommand request = RemotingCommand.createRequestCommand(RequestCode.QUERY_DATA_VERSION, requestHeader);
+ request.setBody(topicConfigWrapper.getDataVersion().encode());
+ RemotingCommand response = remotingClient.invokeSync(namesrvAddr, request, timeoutMills);
+ DataVersion nameServerDataVersion = null;
+ assert response != null;
+ Boolean changed = false;
+ switch (response.getCode()) {
+ case ResponseCode.SUCCESS: {
+ QueryDataVersionResponseHeader queryDataVersionResponseHeader =
+ (QueryDataVersionResponseHeader) response.decodeCommandCustomHeader(QueryDataVersionResponseHeader.class);
+ changed = queryDataVersionResponseHeader.getChanged();
+ byte[] body = response.getBody();
+ if (body != null) {
Review comment:
null or empty byte array?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services