You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kaxil (via GitHub)" <gi...@apache.org> on 2026/08/11 19:55:49 UTC
[PR] Interrupt a running Anthropic session before archiving it [airflow]
kaxil opened a new pull request, #71465:
URL: https://github.com/apache/airflow/pull/71465
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Interrupt a running Anthropic session before archiving it [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #71465:
URL: https://github.com/apache/airflow/pull/71465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Interrupt a running Anthropic session before archiving it [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #71465:
URL: https://github.com/apache/airflow/pull/71465#discussion_r3764971732
##########
providers/anthropic/tests/unit/anthropic/hooks/test_anthropic.py:
##########
@@ -266,6 +268,42 @@ def test_rejects_bad_amounts(self, amount, match):
build_budget(amount)
+def _bad_request(message="cannot be archived while its status is running"):
Review Comment:
```suggestion
def _make_bad_request(message="cannot be archived while its status is running") -> BadRequestError:
```
##########
providers/anthropic/src/airflow/providers/anthropic/hooks/anthropic.py:
##########
@@ -694,15 +695,58 @@ def send_event(self, session_id: str, event: dict[str, Any]) -> Any:
session_id, events=cast("list[BetaManagedAgentsEventParams]", [event])
)
- def archive_session(self, session_id: str) -> BetaManagedAgentsSession:
+ def interrupt_session(self, session_id: str) -> Any:
Review Comment:
do we want to make it a public method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Interrupt a running Anthropic session before archiving it [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #71465:
URL: https://github.com/apache/airflow/pull/71465#discussion_r3765829451
##########
providers/anthropic/src/airflow/providers/anthropic/hooks/anthropic.py:
##########
@@ -694,15 +695,58 @@ def send_event(self, session_id: str, event: dict[str, Any]) -> Any:
session_id, events=cast("list[BetaManagedAgentsEventParams]", [event])
)
- def archive_session(self, session_id: str) -> BetaManagedAgentsSession:
+ def interrupt_session(self, session_id: str) -> Any:
Review Comment:
Kept public, deliberately. `archive_session` is the only in-tree caller today, but the two have different time budgets: archiving retries for roughly 25s at the defaults, while a task's `on_kill` is SIGKILLed a few seconds in. A caller that just wants to stop billable runtime and let the session settle has a real use for the interrupt on its own.
It is also a thin wrapper over the already-public `send_event`, so making it private would hide the name without removing the capability. Happy to flip it if you would rather keep the surface minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Interrupt a running Anthropic session before archiving it [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #71465:
URL: https://github.com/apache/airflow/pull/71465#discussion_r3765828045
##########
providers/anthropic/tests/unit/anthropic/hooks/test_anthropic.py:
##########
@@ -266,6 +268,42 @@ def test_rejects_bad_amounts(self, amount, match):
build_budget(amount)
+def _bad_request(message="cannot be archived while its status is running"):
Review Comment:
Applied verbatim, plus both call sites. `BadRequestError` was already imported at module level, so no import change was needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org