You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org> on 2022/07/14 03:35:22 UTC

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent.

Xiaoqing Gao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18729


Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent.
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables
This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/query_test/test_kudu.py
4 files changed, 156 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#8).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
6 files changed, 192 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#3).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/query_test/test_kudu.py
4 files changed, 159 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10966/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 04:03:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.

Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 12: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 06:23:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 13:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11287/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 09:02:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/15/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/15/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@222
PS15, Line 222: srcTable
Do we need to check the target table as well? Could you add a test in this format?

 CRETE TABLE kudu_tbl sort by xxx LIKE xxx stored as kudu;



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 01:34:40 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#21).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, except for one
limitation. It is not supported to clone a Kudu table with range
paritions. Because there is no elegant way to convert List<String>
to RangePartition object.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 189 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/21
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 21
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 34: Code-Review+2

LGTM. Carrying Wenzhen's +1. Thanks for your long efforts on making this done, Xiaoqing!


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 34
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Feb 2023 11:36:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#5).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
5 files changed, 174 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 7:

(5 comments)

Thanks for adding more tests!

http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@223
PS7, Line 223:           + " cannot be cloned because it cannot be cloned into a "
It'd be better to mention the original table type. Maybe we can reword this to something like

 CREATE TABLE LIKE is not supported between kudu tables and parquet tables.


http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3786
PS7, Line 3786: extractCreateTableParams
nit: This only works for kudu tables so "extractKuduCreateTableParams" might be better.


http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3802
PS7, Line 3802: hava
typo? "having range partitions" ?


http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:

http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/datasets/functional/functional_schema_template.sql@266
PS7, Line 266: PARTITION BY HASH (id) PARTITIONS 3 STORED AS KUDU;
It's an existing bug that we missed the comment here. Could you fix this to the following?

 PARTITION BY HASH (id) PARTITIONS 3
 COMMENT 'Tiny table'
 STORED AS KUDU;

With this, we can add tests on table comments using functional_kudu.alltypestiny?


http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test:

http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test@96
PS7, Line 96: hava
typo?



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Jul 2022 02:23:07 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/8/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/8/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219
PS8, Line 219:       if (targeTableFileFormat == null) {
             :         targeTableFileFormat = THdfsFileFormat.KUDU;
             :       }
> In statement, "create table kudu_alltypestiny_clone like functional_kudu.al
hmm, the above if-statement contains two branches. The first branch has "fileFormat_ == THdfsFileFormat.KUDU". The second branch has "fileFormat_ != null". I think 'fileFormat_' won't be null. Thus 'targeTableFileFormat' won't be null here.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 09:15:51 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#14).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 178 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/14
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 14
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 15:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8526/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 11:58:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#20).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, except for one
limitation. It is not supported to clone a Kudu table with range
paritions. Because there is no elegant way to convert List<String>
to RangePartition object.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 188 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/20
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 20
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

The patch LGTM. I just have a minor comment. I can bump to +2 if other reviewers have no comments. Thanks!

http://gerrit.cloudera.org:8080/#/c/18729/10/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/10/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@211
PS10, Line 211: ensureCreateKuduTableParamsValid
nit: "validateCreateKuduTableParams" sounds better



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Sun, 31 Jul 2022 08:40:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 28:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/18729/28/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java:

http://gerrit.cloudera.org:8080/#/c/18729/28/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@151
PS28, Line 151:         for (RangeWithHashSchema rangeWithHashSchema: partitionSchema.getRangesWithHashSchemas()) {
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/28/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@162
PS28, Line 162:         }            
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18729/28/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@163
PS28, Line 163:         
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18729/28/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@175
PS28, Line 175:             
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18729/28/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@177
PS28, Line 177:                 new Pair<List<Expr>, Boolean>(startLiterals, true), null, hashSpecList.get(i++));
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/28/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@183
PS28, Line 183:                 null, new Pair<List<Expr>, Boolean>(endLiterals, false), hashSpecList.get(i++));
line too long (96 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 28
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 04:37:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 29:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/29/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java:

http://gerrit.cloudera.org:8080/#/c/18729/29/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@151
PS29, Line 151:         for (RangeWithHashSchema rangeWithHashSchema :
Hi, Alexey

Can this interface be public for users to call? https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java#L213
 
I also tried calling other interfaces. For example, the create statement is as follows:
create table custom_hash_range_single (id int, c2 int, primary key(id, c2))
partition by hash(id) partitions 3,
range (c2)
(
    partition 0 <= values < 10
  , partition 10 <= values < 20 hash partitions 2
  , partition 20 <= values < 30 hash(c2) partitions 3
  , partition 30 <= values < 40 hash(id) partitions 4
  , partition 40 <= values < 50 hash(id, c2) partitions 5
)
stored as kudu;

For this case, kuduTable.getRangePartitions(BackendConfig.INSTANCE.getKuduClientTimeoutMs()) returns five partitions.
partitionSchema.getRangesWithHashSchemas() returns four range with hash schemas. I didn't find a flag that can match the two one by one.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 29
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 04:38:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 33:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12378/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 33
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 15 Feb 2023 10:15:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#29).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
10 files changed, 384 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/29
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 29
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#10).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
6 files changed, 189 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/10
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.

Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 26:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@212
PS26, Line 212: statement is different
nit: statements are different.


http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@212
PS26, Line 212: kudu
nit: Kudu


http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java:

http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@152
PS26, Line 152: // create RangePartition
IMPALA-11430 added support for custom hash partition specification at the range partition level for Kudu range tables (https://gerrit.cloudera.org/#/c/18676). The hash specification in range partition should be cloned from source table if there is any.


http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@186
PS26, Line 186: public
nit: change to private


http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/util/KuduUtil.java
File fe/src/main/java/org/apache/impala/util/KuduUtil.java:

http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/util/KuduUtil.java@504
PS26, Line 504: k
nit: Kudu



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 26
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 07 Nov 2022 20:41:05 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#13).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 174 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/13
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#17).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 182 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/17
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 17
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/15/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/15/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@222
PS15, Line 222: srcTable
> Do we need to check the target table as well? Could you add a test in this 
If srcTable is kudu type, the target table is also kudu type. The previous if statement judged. 
I added this test in
https://gerrit.cloudera.org/#/c/18729/17/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 02:55:54 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 20:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG@9
PS18, Line 9: between Kudu tables,
> Could you list limitations of this implementations, e.g. not being able to 
It is not supported to clone a Kudu table with range paritions. No other limitations.


http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG@10
PS18, Line 10: limita
> Cloning
Done


http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@173
PS18, Line 173: analyzer.ensureTableNotBucketed(srcTable);
> Just to clarify: does this mean that a Kudu table with hash partitions cann
Hive create bucketed table and specified 'CLUSTERED BY (column_a) INTO n BUCKETS', for example:

CREATE TABLE `user_info_bucketed`(
  `user_id` bigint,
  `firstname` string,
  `lastname` string)
COMMENT 'A bucketed copy of user_info'
PARTITIONED BY (
  `ds` string)
CLUSTERED BY (
  user_id)
INTO 16 BUCKETS

The table `user_info_bucketed` has 16 buckets. 

When impala access `user_info_bucketed` and execute following query: create table `user_cloned` like `user_info_bucketed`. 

The function ensureTableNotBucketed(srcTable) will throw AnalysisException: default.user_info_bucketed is a bucketed table.

When a kudu table with hash partitions, The bucket is 0. It can be cloned.


http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3840
PS18, Line 3840:       if (tbl.getParameters().containsKey(IcebergTable.ICEBERG_CATALOG)) {
> It would be great to add a comment in the code to shed more light on what p
I added the comment. When getting range partitions List<String> by kudu client, there is no elegant way to convert List<String> to fe/src/main/java/org/apache/impala/analysis/RangePartition.java


http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2448
PS18, Line 2448:     // Kudu tables with range partitions cannot be cloned
> Does it make sense to add more AnalysisError() to reflect on other restrict
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 20
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 06:27:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#19).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, except for one limitation.
It is not supported to clone a Kudu table with range paritions. Because there
is no elegant way to convert String to RangePartition object.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 188 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/19
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 19
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 22: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 22
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 08:31:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 35: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 35
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Feb 2023 11:36:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#6).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
5 files changed, 183 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#9).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
6 files changed, 193 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 7:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@223
PS7, Line 223:           + " cannot be cloned because it cannot be cloned into a "
> It'd be better to mention the original table type. Maybe we can reword this
I also think it'd be better to mention the original table type, but I didn't find the proper way to get the original table type from FeTable.


http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3786
PS7, Line 3786: extractCreateTableParams
> nit: This only works for kudu tables so "extractKuduCreateTableParams" migh
Done


http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3802
PS7, Line 3802: hava
> typo? "having range partitions" ?
Done


http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:

http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/datasets/functional/functional_schema_template.sql@266
PS7, Line 266: PARTITION BY HASH (id) PARTITIONS 3 STORED AS KUDU;
> It's an existing bug that we missed the comment here. Could you fix this to
Done


http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test:

http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test@96
PS7, Line 96: hava
> typo?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 07:58:03 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/8/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/8/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219
PS8, Line 219:       if (targeTableFileFormat == null) {
             :         targeTableFileFormat = THdfsFileFormat.KUDU;
             :       }
> hmm, the above if-statement contains two branches. The first branch has "fi
Sorry about that stupid mistake, I fix it.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:03:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#12).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
6 files changed, 189 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/12
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 29:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/12026/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 29
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 04:48:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#15).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 177 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/15
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 17:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11293/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 17
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 03:05:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 19:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11450/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 19
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 06:45:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.

Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 34: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 34
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Feb 2023 05:31:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/10965/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 03:46:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11047/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 09:57:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 11: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Aug 2022 06:23:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/9/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/9/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@224
PS9, Line 224:           "%s cannot be cloned into a %s table: CREATE TABLE LIKE is not supported between kudu tables and non-kudu tables.",
line too long (125 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 09:26:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 32:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/12361/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 32
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Feb 2023 10:16:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 26:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11805/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 26
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 07 Nov 2022 03:30:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#26).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
10 files changed, 363 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/26
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 26
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 22:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8628/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 22
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 03:17:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 19:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/19/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/19/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@235
PS19, Line 235:               "CREATE TABLE LIKE is not supported for Kudu tables having range partition.");
line too long (92 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 19
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 06:22:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#34).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, including clone the
schema and hash partitions. But there is one limitation, cloning of
Kudu tables with range paritions is not supported. For cloning range
partitions, it's tracked by IMPALA-11912.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statements are different.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
8 files changed, 232 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/34
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 34
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10967/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 04:30:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 4:

(1 comment)

Thanks for working on this feature!

http://gerrit.cloudera.org:8080/#/c/18729/4/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test:

http://gerrit.cloudera.org:8080/#/c/18729/4/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test@4
PS4, Line 4: create table kudu_alltypes_clone like functional_kudu.alltypes
Can we add a negative test for cloning from a partitioned table of other types, e.g. functional.alltypes? We can use the "---- CATCH" section to catch expected failures.

I think we also need tests on cases when Kudu-HMS integration is enabled/disabled.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 14:05:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 18:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG@9
PS18, Line 9: between Kudu tables.
Could you list limitations of this implementations, e.g. not being able to clone a Kudu table with range partitions, etc.  Any other limitations, BTW?


http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG@10
PS18, Line 10: Cloing
Cloning


http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@173
PS18, Line 173: analyzer.ensureTableNotBucketed(srcTable);
Just to clarify: does this mean that a Kudu table with hash partitions cannot be cloned either?


http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3840
PS18, Line 3840:     for (KuduPartitionParam kuduPartitionParam : kuduTable.getPartitionBy()) {
It would be great to add a comment in the code to shed more light on what prevents cloning Kudu tables with range partitions.  When reading this code, it seems a bit strange that cloning a hash-partitioned Kudu table is possible, but cloning a range-partitioned Kudu table is not.


http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2448
PS18, Line 2448: 
Does it make sense to add more AnalysisError() to reflect on other restrictions:
  * Kudu tables with range partitions cannot be cloned
  * Kudu tables with hash partitions cannot be cloned (is that true, BTW?)?

That's just to be explicit what to expect when a request to clone such Kudu table arrives.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 18
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 23:03:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 25:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11791/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 25
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:59:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 12:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11250/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 06:28:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11056/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 09:45:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, including clone the
schema and hash partitions. But there is one limitation, cloning of
Kudu tables with range paritions is not supported. For cloning range
partitions, it's tracked by IMPALA-11912.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statements are different.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Reviewed-on: http://gerrit.cloudera.org:8080/18729
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
8 files changed, 232 insertions(+), 17 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 36
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 29:

Sorry to see this being pending for so long.. I think cloning the range partitions is a futher feature and we can do it in a separate patch. Note that CreateTableLike for HDFS tables doesn't clone the partitions. Range partitions in Kudu tables are similar to the partitions in HDFS tables. I think it's ok to not clone them, or provide users the ability to choose the behavior. On the other side, cloning all the range partitions of a large kudu table might take a long time. Users might just want to create a tiny table for testing.

I suggest spill over the support of cloning range partitions into a separate patch, and let this patch focus on only cloning the schema (including hash partitions). In the follow-on patch, we can add query option or new syntax for cloning range partitions as well. What do you think?


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 29
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Feb 2023 02:02:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 32:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/32/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/32/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3930
PS32, Line 3930: createTableParams.setPrimary_key_column_names(kuduTable.getPrimaryKeyColumnNames());
               :     List<TColumn> columns = new ArrayList<>();
               :     for (Column col : kuduTable.getColumns()) {
               :       columns.add(col.toThrift());
               :     }
> IMPALA-11809 was merged recently, which added support for non unique primar
I fixed it and added some tests. Thanks for the reminder.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 32
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 15 Feb 2023 09:59:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#28).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
10 files changed, 382 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/28
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 28
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10968/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 06:04:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 9:

Build Successful 

https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/11032/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 09:46:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 12: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8509/


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 10:59:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#16).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 182 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/16
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 16
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 14:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18729/14/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/18729/14/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2435
PS14, Line 2435:         "functional.alltypestiny cannot be cloned into a KUDU table: CREATE TABLE LIKE is not " +
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/14/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2442
PS14, Line 2442:         "create table kudu_decimal_tbl_clone sort by (d1, d2) like functional_kudu.decimal_tbl",
line too long (96 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 14
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 10:58:41 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 21: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8624/


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 21
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 13:27:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#31).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, including clone the
schema and hash partitions. But there is one limitation, cloning of
Kudu tables with range paritions is not supported. For cloning range
partitions, it's tracked by IMPALA-11912.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 186 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/31
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 31
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#32).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, including clone the
schema and hash partitions. But there is one limitation, cloning of
Kudu tables with range paritions is not supported. For cloning range
partitions, it's tracked by IMPALA-11912.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statements are different.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 186 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/32
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 32
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.

Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 33:

(2 comments)

Thanks to fix the issue for non unique primary key. It looks good to me, only a few nits.

http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3934
PS33, Line 3934: assigned
nit: created


http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3940
PS33, Line 3940: List<String> primaryColumnNames = new ArrayList<>();
               :     for (String primaryColumnName : kuduTable.getPrimaryKeyColumnNames()) {
               :       if (KuduUtil.getAutoIncrementingColumnName().equals(primaryColumnName)) continue;
               :       primaryColumnNames.add(primaryColumnName);
               :     }
nit: a little optimization to avoid checking auto-incrementing column for table with unique key. 
List<String> primaryColumnNames = new ArrayList(kuduTable.getPrimaryKeyColumnNames());
if (kuduTable.hasAutoIncrementingColumn()) {
  primaryColumnNames.remove(KuduUtil.getAutoIncrementingColumnName());
}



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 33
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 15 Feb 2023 18:20:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 33:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3934
PS33, Line 3934: assigned
> nit: created
Done


http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3940
PS33, Line 3940: List<String> primaryColumnNames = new ArrayList<>();
               :     for (String primaryColumnName : kuduTable.getPrimaryKeyColumnNames()) {
               :       if (KuduUtil.getAutoIncrementingColumnName().equals(primaryColumnName)) continue;
               :       primaryColumnNames.add(primaryColumnName);
               :     }
> nit: a little optimization to avoid checking auto-incrementing column for t
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 33
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Feb 2023 04:12:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 18:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219
PS18, Line 219: kudu
nit: Kudu


http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219
PS18, Line 219: non-kudu
nit: non-Kudu



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 18
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 17:09:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#27).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
10 files changed, 363 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/27
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 27
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 26:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@212
PS26, Line 212: kudu
> nit: Kudu
Done


http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@212
PS26, Line 212: statement is different
> nit: statements are different.
Done


http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java:

http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@152
PS26, Line 152: // create RangePartition
> IMPALA-11430 added support for custom hash partition specification at the r
Thanks for your review!
The version of Kudu that Impala reference is 956093dd9d. The getRangesWithHashSchemas() in current Kudu version is not public.

https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java#L180

Bump Kudu version to 856fa3404b can resolve. I'll try.


http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@186
PS26, Line 186: public
> nit: change to private
Done


http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/util/KuduUtil.java
File fe/src/main/java/org/apache/impala/util/KuduUtil.java:

http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/util/KuduUtil.java@504
PS26, Line 504: k
> nit: Kudu
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 26
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Nov 2022 10:34:07 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.

Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 11: Code-Review+1

(2 comments)

Looks good, only a few nit

http://gerrit.cloudera.org:8080/#/c/18729/11//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18729/11//COMMIT_MSG@10
PS11, Line 10: because the
nit: line is too long


http://gerrit.cloudera.org:8080/#/c/18729/11/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test:

http://gerrit.cloudera.org:8080/#/c/18729/11/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test@93
PS11, Line 93: CREATE TABLE LIKE on partitioned table
nit: CREATE TABLE LIKE from non-Kudu table



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 12 Aug 2022 23:27:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 29:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/29/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java:

http://gerrit.cloudera.org:8080/#/c/18729/29/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@151
PS29, Line 151:         for (RangeWithHashSchema rangeWithHashSchema :
> Hi, Alexey
Hi Xiaoqing,

I apologize for the late response -- I somehow missed this update.

It seems the current API isn't a straight fit for your purpose here.  Yes, PartitionSchema.getRangesWithHashSchemas() returns only ranges with _custom_ hash schemas, it doesn't return ranges with the table-wide schema.  That's so by design because the original PartitionSchema concept had no knowledge on the ranges in the table.  So, it is static in that regard and doesn't contain information on all range partitions in the table, while information on ranges with custom hash schemas is some sort of exception for particular ranges with overrides for the table-wide hash schema (it's supposed there is not so many overrides in a table).

Having the list of range partitions in a Kudu table without information on hash schemas, it's still possible to find hash schema information for every existing range.  If the range isn't in the list returned by PartitionSchema.getRangesWithHashSchemas(), then it has the table-wide hash schema.  The table-wide hash schema is what PartitionSchema.getHashBucketSchemas() returns.

Having this information, do you think you can make this work for the purpose of the createTableRangePartition() method begin added in this patch or you'd rather have PartitionSchema.getHashSchemaForRange() available in the impala package?

Thanks!


P.S. The interface you referred isn't public since it was not needed for IMPALA-11430 or anything else yet (see https://github.com/apache/impala/commit/7764830216d2d2d9a85ec7a6a7deb4badecb13a8), and it was enough to add KuduTable.getFormattedRangePartitionsWithHashSchema() method similar to KuduTable.getFormattedRangePartitions().



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 29
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 13 Jan 2023 00:42:54 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#18).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 181 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/18
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 18
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 14:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11288/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 14
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 11:18:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 16:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18729/16/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/18729/16/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2445
PS16, Line 2445:         "create table kudu_decimal_tbl_clone sort by (d1, d2) like " + 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18729/16/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2446
PS16, Line 2446:         "functional_kudu.decimal_tbl stored as kudu", 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18729/16/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2447
PS16, Line 2447:         "functional_kudu.decimal_tbl cannot be cloned because SORT BY is " + 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 16
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 02:44:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 16:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11292/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 16
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 03:03:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11055/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:09:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/4/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test:

http://gerrit.cloudera.org:8080/#/c/18729/4/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test@4
PS4, Line 4: create table kudu_alltypes_clone like functional_kudu.alltypes
> Can we add a negative test for cloning from a partitioned table of other ty
Thanks for your review!
I added four tests catch expected failures and add e2e case in TestKuduHMSIntegration.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 09:36:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 10:

Build Successful 

https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/11034/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:19:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent.
......................................................................


Patch Set 1:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@217
PS1, Line 217:   private void ensureCreateKuduTableParamsValid(FeTable srcTable) throws AnalysisException {
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219
PS1, Line 219:     if ((fileFormat_ == THdfsFileFormat.KUDU && !KuduTable.isKuduTable(srcTable.getMetaStoreTable())) || (fileFormat_ != null && fileFormat_ != THdfsFileFormat.KUDU && KuduTable.isKuduTable(srcTable.getMetaStoreTable()))) {
line too long (223 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@221
PS1, Line 221:         throw new AnalysisException(srcTable.getFullName() + " cannot be cloned because SORT BY is not supported for Kudu tables.");
line too long (132 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@227
PS1, Line 227:       throw new AnalysisException(srcTable.getFullName() + " cannot be cloned because it cannot be cloned into a " + targeTableFileFormat.toString() + " table.");
line too long (162 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3776
PS1, Line 3776:       TCreateTableParams createTableParams = extractCreateTableParams(params, tblName, (KuduTable)srcTable, tbl);
line too long (113 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3787
PS1, Line 3787:   private TCreateTableParams extractCreateTableParams(TCreateTableLikeParams params, TableName tblName, KuduTable kuduTable,
line too long (124 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3801
PS1, Line 3801:         throw new UnsupportedOperationException("CREATE TABLE LIKE is not supported for Kudu tables hava range partition.");
line too long (124 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3809
PS1, Line 3809:     tableProperties.put(KuduTable.KEY_TABLE_NAME, String.format("%s::%s:%s", params.getOwner(), tblName.getDb(), tblName.getTbl()));
line too long (132 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/18729/1/tests/query_test/test_kudu.py@92
PS1, Line 92: a
flake8: E501 line too long (96 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 03:36:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18729/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@169
PS2, Line 169:     
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18729/2/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/18729/2/tests/query_test/test_kudu.py@90
PS2, Line 90: a
flake8: E501 line too long (96 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 03:42:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/3/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/18729/3/tests/query_test/test_kudu.py@91
PS3, Line 91: '
flake8: E126 continuation line over-indented for hanging indent



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 04:09:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 18:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219
PS18, Line 219: kudu
> nit: Kudu
Done


http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219
PS18, Line 219: non-kudu
> nit: non-Kudu
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 18
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 07 Nov 2022 03:11:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 24:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11790/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 24
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:18:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 23:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11789/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 23
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:12:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8509/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 06:15:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 18:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11294/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 18
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 03:50:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/12/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/12/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@223
PS12, Line 223:     if (sortColumns_ != null) {
This causes the test failure. We should only check this when the target table is a Kudu table.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Sun, 04 Sep 2022 12:30:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 28:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/12025/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 28
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 04:47:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 21:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8624/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 21
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 08:06:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 22:

Hit by IMPALA-11572


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 22
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 03:15:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 21:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11451/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 21
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 07:00:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 35:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9061/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 35
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Feb 2023 11:36:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 35: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 35
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Feb 2023 16:38:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 22:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3840
PS18, Line 3840:       Map<String, String> tableProperties = Maps
> I added the comment. When getting range partitions List<String> by kudu cli
Can we use this method? It returns a list of org.apache.kudu.client.Partition

https://github.com/apache/kudu/blob/f55c80e75848461eef21c3cdb6f43d907999bfdf/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java#L340



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 22
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 17 Oct 2022 11:15:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18729/5/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/5/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@213
PS5, Line 213:     // Only clone between kudu tables because the kudu table and  information is inconsistent.
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/5/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/18729/5/tests/custom_cluster/test_kudu.py@341
PS5, Line 341: a
flake8: E501 line too long (96 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 09:13:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/8/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/8/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219
PS8, Line 219:       if (targeTableFileFormat == null) {
             :         targeTableFileFormat = THdfsFileFormat.KUDU;
             :       }
> Do we need this? It seems 'fileFormat_' won't be null here.
In statement, "create table kudu_alltypestiny_clone like functional_kudu.alltypestiny" don't have statement "store as kudu", the targetTableFileFormat is null. Actually it has same table type with source table type.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:38:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#11).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
6 files changed, 189 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/11
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent.

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has restored this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent.
......................................................................


Restored
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#23).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, except for one
limitation. It is not supported to clone a Kudu table with range
paritions. Because there is no elegant way to convert List<String>
to RangePartition object.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/analysis/RangePartition.java
M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
11 files changed, 363 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/23
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 23
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#24).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
10 files changed, 362 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/24
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 24
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 18:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3840
PS18, Line 3840:     for (KuduPartitionParam kuduPartitionParam : kuduTable.getPartitionBy()) {
> Can we use this method? It returns a list of org.apache.kudu.client.Partiti
Thanks for your advice. I use this kudu api to create 
https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/analysis/RangePartition.java#L98



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 18
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:07:07 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#25).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
10 files changed, 363 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/25
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 25
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 34:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12385/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 34
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Feb 2023 04:30:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#2).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/query_test/test_kudu.py
4 files changed, 157 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent.

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has abandoned this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent.
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#4).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/query_test/test_kudu.py
4 files changed, 154 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18729/6/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/18729/6/tests/custom_cluster/test_kudu.py@49
PS6, Line 49: a
flake8: E126 continuation line over-indented for hanging indent


http://gerrit.cloudera.org:8080/#/c/18729/6/tests/custom_cluster/test_kudu.py@68
PS6, Line 68: i
flake8: E126 continuation line over-indented for hanging indent



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 09:25:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#7).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables.
Cloing Kudu tables from other types of tables is not implemented, because the
table creation statement is not completely consistent.

Testing:
 - e2e tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
5 files changed, 177 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11045/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 09:38:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11046/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 09:52:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11058/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:19:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 11:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11067/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Aug 2022 04:06:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@223
PS7, Line 223:           + " cannot be cloned because it cannot be cloned into a "
> I also think it'd be better to mention the original table type, but I didn'
I see. Maybe the simplest way is FeFsTable#getFileFormats(). But it doesn't work for HBase tables. I'm ok with the current message with a little modification:

 foo cannot be cloned into a xxx table: CREATE TABLE LIKE is not supported between kudu tables and non-kudu tables.


http://gerrit.cloudera.org:8080/#/c/18729/8/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/8/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219
PS8, Line 219:       if (targeTableFileFormat == null) {
             :         targeTableFileFormat = THdfsFileFormat.KUDU;
             :       }
Do we need this? It seems 'fileFormat_' won't be null here.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:20:05 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 27:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11819/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 27
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 09 Nov 2022 10:20:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 15: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 16:47:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 8:

Build Successful 

https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/11031/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:31:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 13:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18729/13/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/18729/13/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2435
PS13, Line 2435:         "functional.alltypestiny cannot be cloned into a KUDU table: CREATE TABLE LIKE is not supported between kudu tables and non-kudu tables.");
line too long (147 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/13/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2438
PS13, Line 2438:         "functional_kudu.alltypes cannot be cloned into a PARQUET table: CREATE TABLE LIKE is not supported between kudu tables and non-kudu tables.");
line too long (151 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/13/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2440
PS13, Line 2440:         "create table kudu_decimal_tbl_clone sort by (d1, d2) like functional_kudu.decimal_tbl",
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/18729/13/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2441
PS13, Line 2441:         "functional_kudu.decimal_tbl cannot be cloned because SORT BY is not supported for Kudu tables.");
line too long (106 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 08:42:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 15:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11289/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 11:27:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 29:

(1 comment)

Hi Quanlong,
Sorry for taking so long. I also think that splitting the patch is an efficient way.
I changed this patch focus on only cloning the schema. In https://issues.apache.org/jira/browse/IMPALA-11912, it focus on cloning range partitions.

http://gerrit.cloudera.org:8080/#/c/18729/29/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java:

http://gerrit.cloudera.org:8080/#/c/18729/29/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@151
PS29, Line 151:         for (RangeWithHashSchema rangeWithHashSchema :
> Hi Xiaoqing,
Thanks for your very detailed description and advice. It seems that the following interfaces can be used to implement function.

The definition of RangeWithHashSchema object returned by PartitionSchema.getRangesWithHashSchemas() is
public static class RangeWithHashSchema {
  public PartialRow lowerBound;
  public PartialRow upperBound;
  public List<HashBucketSchema> hashSchemas;
}

The following interface gets the decoded start range key and end range key of each range partition.
PartialRow rangeKeyStart = partition.getDecodedRangeKeyStart(kuduTable);
PartialRow rangeKeyEnd = partition.getDecodedRangeKeyEnd(kuduTable);
https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java#L104
https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java#L126

Looks like I need to use the following interface to compare the PartialRow objects(rangeKeyStart/rangeKeyEnd in each range partition and lowerBound/upperBound in each returned by PartitionSchema.getRangesWithHashSchemas()).
https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java#L1715

It will be subimited in the follow-on patch, tracked by https://issues.apache.org/jira/browse/IMPALA-11912



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 29
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Feb 2023 09:23:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#30).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, including clone the
schema and hash partitions. But there is one limitation, cloning of
Kudu tables with range paritions is not supported. For cloning range
partitions, it's tracked by
https://issues.apache.org/jira/browse/IMPALA-11912

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statement is not completely consistent.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
7 files changed, 186 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/30
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 30
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 30:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/12360/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 30
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Feb 2023 09:23:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.

Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 32:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/32/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18729/32/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3930
PS32, Line 3930: createTableParams.setPrimary_key_column_names(kuduTable.getPrimaryKeyColumnNames());
               :     List<TColumn> columns = new ArrayList<>();
               :     for (Column col : kuduTable.getColumns()) {
               :       columns.add(col.toThrift());
               :     }
IMPALA-11809 was merged recently, which added support for non unique primary key. If the source table has non unique primary key, auto_incrementing_id column was added when the source table was created. auto_incrementing_id column must be skipped when cloning a new Kudu table, otherwise Kudu will throw exception. If you think it's too complicated, I can fix it in a follow on patch.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 32
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Feb 2023 06:11:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Kurt Deschler, Alexey Serbin, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18729

to look at the new patch set (#33).

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................

IMPALA-4052: CREATE TABLE LIKE for Kudu tables

This commit implements cloning between Kudu tables, including clone the
schema and hash partitions. But there is one limitation, cloning of
Kudu tables with range paritions is not supported. For cloning range
partitions, it's tracked by IMPALA-11912.

Cloning Kudu tables from other types of tables is not implemented,
because the table creation statements are different.

Testing:
 - e2e tests
 - AnalyzeDDLTest tests

Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test
M tests/custom_cluster/test_kudu.py
M tests/query_test/test_kudu.py
8 files changed, 232 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/18729/33
-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 33
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>