[GitHub] [echarts] Ovilia commented on a diff in pull request #17278: feat(dataZoom): `valueRange` for `dataZoom` event

[GitBox <gi...@apache.org>]

Ovilia commented on code in PR #17278:
URL: https://github.com/apache/echarts/pull/17278#discussion_r905665464


##########
src/component/dataZoom/SliderZoomView.ts:
##########
@@ -816,6 +817,7 @@ class SliderZoomView extends DataZoomView {
                         start: range[0], end: range[1]
                     }).valueWindow
                     : axisProxy.getDataValueWindow();
+                this._valueRange = dataInterval;

Review Comment:
   So if `showDetail` is false, this value range is not updated. Is this expected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org