You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/11 06:28:37 UTC
[GitHub] [pulsar] pheecian opened a new pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
pheecian opened a new pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717
…pull/6697
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #6692
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #6692
### Motivation
avoid prefetch too much data when offloading, which may lead to OOM;
fix object not close issue, which is also mentioned by congbobo184 https://github.com/apache/pulsar/pull/6697
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-612729909
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407199956
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -62,12 +65,14 @@
private final FileSystem fileSystem;
private OrderedScheduler scheduler;
private static final long ENTRIES_PER_READ = 100;
+ private static final int PREFETCH_ROUNDS = 100;
Review comment:
One per reading is ok, the PREFETCH_ROUNDS unnecessary to big.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #6717: Avoid prefetch too
much data when offloading data to HDFS
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on issue #6717: Avoid prefetch too much data when offloading data to HDFS
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-613201733
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
pheecian commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-612751266
@congbobo184 need I handle the CI-Integration test fail? I think it is not related to this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
pheecian commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-612578150
@congbobo184 Is it possible for you to review the PR again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on a change in pull request #6717:
Avoid prefetch too much data when offloading data to HDFS
Posted by GitBox <gi...@apache.org>.
pheecian commented on a change in pull request #6717: Avoid prefetch too much data when offloading data to HDFS
URL: https://github.com/apache/pulsar/pull/6717#discussion_r408117396
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -188,13 +192,17 @@ public void run() {
AtomicLong haveOffloadEntryNumber = new AtomicLong(0);
long needToOffloadFirstEntryNumber = 0;
CountDownLatch countDownLatch;
+ //avoid prefetch too much data into memory
+ Semaphore semaphore = new Semaphore(1);
Review comment:
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6717: Avoid prefetch too
much data when offloading data to HDFS
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6717: Avoid prefetch too much data when offloading data to HDFS
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-613251607
@sijie @jiazhai Please help review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
pheecian commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-612628494
@congbobo184 your comment makes sense. I have update the code. Thanks. Any more modification for me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407208975
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -62,12 +65,14 @@
private final FileSystem fileSystem;
private OrderedScheduler scheduler;
private static final long ENTRIES_PER_READ = 100;
+ private static final int PREFETCH_ROUNDS = 100;
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
pheecian commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-612347402
@congbobo184 is it possible for you to review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407200187
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -132,8 +138,8 @@ public FileSystemManagedLedgerOffloader(OffloadPolicies conf, OrderedScheduler s
}
/*
- * ledgerMetadata stored in an index of -1
- * */
+ * ledgerMetadata stored in an index of -1
Review comment:
this format should not be modified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407047633
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -188,12 +191,15 @@ public void run() {
AtomicLong haveOffloadEntryNumber = new AtomicLong(0);
long needToOffloadFirstEntryNumber = 0;
CountDownLatch countDownLatch;
+ //avoid prefetch too much data into memory
+ ArrayBlockingQueue<Boolean> tasks = new ArrayBlockingQueue<>(PREFETCH_ROUNDS);
do {
long end = Math.min(needToOffloadFirstEntryNumber + ENTRIES_PER_READ - 1, readHandle.getLastAddConfirmed());
log.debug("read ledger entries. start: {}, end: {}", needToOffloadFirstEntryNumber, end);
LedgerEntries ledgerEntriesOnce = readHandle.readAsync(needToOffloadFirstEntryNumber, end).get();
+ tasks.put(true);
countDownLatch = new CountDownLatch(1);
- assignmentScheduler.chooseThread(ledgerId).submit(new FileSystemWriter(ledgerEntriesOnce, dataWriter,
+ assignmentScheduler.chooseThread(ledgerId).submit(FileSystemWriter.create(ledgerEntriesOnce, dataWriter, tasks,
Review comment:
I made a comment below @congbobo184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407047545
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -188,12 +191,15 @@ public void run() {
AtomicLong haveOffloadEntryNumber = new AtomicLong(0);
long needToOffloadFirstEntryNumber = 0;
CountDownLatch countDownLatch;
+ //avoid prefetch too much data into memory
+ ArrayBlockingQueue<Boolean> tasks = new ArrayBlockingQueue<>(PREFETCH_ROUNDS);
do {
long end = Math.min(needToOffloadFirstEntryNumber + ENTRIES_PER_READ - 1, readHandle.getLastAddConfirmed());
log.debug("read ledger entries. start: {}, end: {}", needToOffloadFirstEntryNumber, end);
LedgerEntries ledgerEntriesOnce = readHandle.readAsync(needToOffloadFirstEntryNumber, end).get();
Review comment:
the blockingQueue is to block the whole do while loop(to be precisely, the read and submit) Here, not try to limit fileSystemWriter. I understand that the FileSystemWriter will be executed orderly. My intention is to limit the whole do while loop because the do while loop((readAsync().get()) read data from ledger in advance too much too quickly(and lead to consume much memory), more than FileSystemWriter Threads can handle timely. So read in advance, or put in other words, prefetch, should be controlled to some degree. So I introduce a blocking queue and hence a producer-consumer mock-up. the do while loop(read and submit) acts like a producer, the FileSystemWriter acts as a consumer. @congbobo184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-612769425
you don't need to handle the CI-Integration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407159197
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -188,12 +191,15 @@ public void run() {
AtomicLong haveOffloadEntryNumber = new AtomicLong(0);
long needToOffloadFirstEntryNumber = 0;
CountDownLatch countDownLatch;
+ //avoid prefetch too much data into memory
+ ArrayBlockingQueue<Boolean> tasks = new ArrayBlockingQueue<>(PREFETCH_ROUNDS);
do {
long end = Math.min(needToOffloadFirstEntryNumber + ENTRIES_PER_READ - 1, readHandle.getLastAddConfirmed());
log.debug("read ledger entries. start: {}, end: {}", needToOffloadFirstEntryNumber, end);
LedgerEntries ledgerEntriesOnce = readHandle.readAsync(needToOffloadFirstEntryNumber, end).get();
Review comment:
I have understood your min, I look up the code context, I think you can use Semaphore to fix it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #6717: Avoid
prefetch too much data when offloading data to HDFS
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #6717: Avoid prefetch too much data when offloading data to HDFS
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407970453
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -188,13 +192,17 @@ public void run() {
AtomicLong haveOffloadEntryNumber = new AtomicLong(0);
long needToOffloadFirstEntryNumber = 0;
CountDownLatch countDownLatch;
+ //avoid prefetch too much data into memory
+ Semaphore semaphore = new Semaphore(1);
Review comment:
Can we make this configurable? I am worried about this will cause performance problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407208991
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -132,8 +138,8 @@ public FileSystemManagedLedgerOffloader(OffloadPolicies conf, OrderedScheduler s
}
/*
- * ledgerMetadata stored in an index of -1
- * */
+ * ledgerMetadata stored in an index of -1
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
pheecian commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407161477
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -188,12 +191,15 @@ public void run() {
AtomicLong haveOffloadEntryNumber = new AtomicLong(0);
long needToOffloadFirstEntryNumber = 0;
CountDownLatch countDownLatch;
+ //avoid prefetch too much data into memory
+ ArrayBlockingQueue<Boolean> tasks = new ArrayBlockingQueue<>(PREFETCH_ROUNDS);
do {
long end = Math.min(needToOffloadFirstEntryNumber + ENTRIES_PER_READ - 1, readHandle.getLastAddConfirmed());
log.debug("read ledger entries. start: {}, end: {}", needToOffloadFirstEntryNumber, end);
LedgerEntries ledgerEntriesOnce = readHandle.readAsync(needToOffloadFirstEntryNumber, end).get();
Review comment:
nice idea! I will change the code to implement the idea @congbobo184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on a change in pull request #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407030550
##########
File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
##########
@@ -188,12 +191,15 @@ public void run() {
AtomicLong haveOffloadEntryNumber = new AtomicLong(0);
long needToOffloadFirstEntryNumber = 0;
CountDownLatch countDownLatch;
+ //avoid prefetch too much data into memory
+ ArrayBlockingQueue<Boolean> tasks = new ArrayBlockingQueue<>(PREFETCH_ROUNDS);
do {
long end = Math.min(needToOffloadFirstEntryNumber + ENTRIES_PER_READ - 1, readHandle.getLastAddConfirmed());
log.debug("read ledger entries. start: {}, end: {}", needToOffloadFirstEntryNumber, end);
LedgerEntries ledgerEntriesOnce = readHandle.readAsync(needToOffloadFirstEntryNumber, end).get();
+ tasks.put(true);
countDownLatch = new CountDownLatch(1);
- assignmentScheduler.chooseThread(ledgerId).submit(new FileSystemWriter(ledgerEntriesOnce, dataWriter,
+ assignmentScheduler.chooseThread(ledgerId).submit(FileSystemWriter.create(ledgerEntriesOnce, dataWriter, tasks,
Review comment:
```chooseTread(leaderId)``` make sure the second time write will not be executed, so the task meaningless. I don't think it is a good idea to fix the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #6717: Avoid prefetch too
much data when offloading data to HDFS
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on issue #6717: Avoid prefetch too much data when offloading data to HDFS
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-613296257
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on issue #6717: fix filesystem offload oom based on https://github.com/apache/pulsar/…
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-612769042
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pheecian commented on issue #6717: Avoid prefetch too much
data when offloading data to HDFS
Posted by GitBox <gi...@apache.org>.
pheecian commented on issue #6717: Avoid prefetch too much data when offloading data to HDFS
URL: https://github.com/apache/pulsar/pull/6717#issuecomment-613476958
@sijie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services