You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oltu.apache.org by si...@apache.org on 2010/07/09 16:01:09 UTC
svn commit: r962534 -
/incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/AbstractParameter.java
Author: simonetripodi
Date: Fri Jul 9 14:01:09 2010
New Revision: 962534
URL: http://svn.apache.org/viewvc?rev=962534&view=rev
Log:
fixed potential NPE when comparing objects
Modified:
incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/AbstractParameter.java
Modified: incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/AbstractParameter.java
URL: http://svn.apache.org/viewvc/incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/AbstractParameter.java?rev=962534&r1=962533&r2=962534&view=diff
==============================================================================
--- incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/AbstractParameter.java (original)
+++ incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/AbstractParameter.java Fri Jul 9 14:01:09 2010
@@ -68,6 +68,10 @@ abstract class AbstractParameter<N>
* {@inheritDoc}
*/
public final int compareTo(AbstractParameter<N> parameter) {
+ if (parameter == null) {
+ return 1;
+ }
+
int nameComparison = String.valueOf(this.key).compareTo(String.valueOf(parameter.getKey()));
if (0 == nameComparison) {
return this.value.compareTo(parameter.getValue());