You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/24 07:26:19 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #15266: Update Google Ads hook

turbaszek commented on a change in pull request #15266:
URL: https://github.com/apache/airflow/pull/15266#discussion_r619604044



##########
File path: airflow/providers/google/ads/transfers/ads_to_gcs.py
##########
@@ -92,6 +94,7 @@ def __init__(
         page_size: int = 10000,
         gzip: bool = False,
         impersonation_chain: Optional[Union[str, Sequence[str]]] = None,
+        api_version: str = "v5",

Review comment:
       I agree with @dstandish. Using optional and hook's default value as fallback would be best - we will have only one place to change in future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org