You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Arvind Prabhakar <ar...@apache.org> on 2011/11/23 04:29:36 UTC
Review Request: Fixing maven build on trunk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2920/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Summary
-------
The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.
This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.
This addresses bug SQOOP-392.
https://issues.apache.org/jira/browse/SQOOP-392
Diffs
-----
/pom.xml 1205214
/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214
Diff: https://reviews.apache.org/r/2920/diff
Testing
-------
The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.
Also tested the build via ant - and all tests passed successfully.
Thanks,
Arvind
Re: Review Request: Fixing maven build on trunk
Posted by Arvind Prabhakar <ar...@apache.org>.
> On 2011-11-23 07:07:13, Jarek Cecho wrote:
> > Thank you Arvind, changes looks good. Please attach your patch to JIRA and I'll try to do my first commit.
> >
> > Jarcec
Thanks for the review Jarcec. The patch is attached to the JIRA.
- Arvind
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2920/#review3470
-----------------------------------------------------------
On 2011-11-23 03:29:36, Arvind Prabhakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2920/
> -----------------------------------------------------------
>
> (Updated 2011-11-23 03:29:36)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Summary
> -------
>
> The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.
>
> This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.
>
>
> This addresses bug SQOOP-392.
> https://issues.apache.org/jira/browse/SQOOP-392
>
>
> Diffs
> -----
>
> /pom.xml 1205214
> /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214
>
> Diff: https://reviews.apache.org/r/2920/diff
>
>
> Testing
> -------
>
> The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.
>
> Also tested the build via ant - and all tests passed successfully.
>
>
> Thanks,
>
> Arvind
>
>
Re: Review Request: Fixing maven build on trunk
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2920/#review3470
-----------------------------------------------------------
Ship it!
Thank you Arvind, changes looks good. Please attach your patch to JIRA and I'll try to do my first commit.
Jarcec
- Jarek
On 2011-11-23 03:29:36, Arvind Prabhakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2920/
> -----------------------------------------------------------
>
> (Updated 2011-11-23 03:29:36)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Summary
> -------
>
> The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.
>
> This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.
>
>
> This addresses bug SQOOP-392.
> https://issues.apache.org/jira/browse/SQOOP-392
>
>
> Diffs
> -----
>
> /pom.xml 1205214
> /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214
>
> Diff: https://reviews.apache.org/r/2920/diff
>
>
> Testing
> -------
>
> The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.
>
> Also tested the build via ant - and all tests passed successfully.
>
>
> Thanks,
>
> Arvind
>
>