[jira] [Commented] (KAFKA-3881) Remove the replacing logic from "." to "_" in Fetcher

["Andrey Polyakov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489067#comment-17489067 ] 

Andrey Polyakov commented on KAFKA-3881:
----------------------------------------

+1 to this ticket and David's PR.

We have broken Prometheus dashboards for some Kafka client applications because of the inconsistency in metric names or labels due to the sanitation happening in some places and not others. Agree that only Graphite-specific components should be doing the lossy transform, and the raw data be available to systems that don't have this issue.

> Remove the replacing logic from "." to "_" in Fetcher
> -----------------------------------------------------
>
>                 Key: KAFKA-3881
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3881
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer, metrics
>            Reporter: Guozhang Wang
>            Assignee: Tom Bentley
>            Priority: Major
>              Labels: newbie, patch-available
>
> The logic of replacing "." to "_" in metrics names / tags was originally introduced in the core package's metrics since Graphite treats "." as hierarchy separators (see KAFKA-1902); for the client metrics, it is supposed that the GraphiteReported should take care of this itself rather than letting Kafka metrics to special handle for it. In addition, right now only consumer Fetcher had replace, but producer Sender does not have it actually.
> So we should consider removing this logic in the consumer Fetcher's metrics package. NOTE that this is a public API backward incompatible change.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)