You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/06/30 05:31:59 UTC

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2368: Config option to allow only secured client connections

eolivelli commented on a change in pull request #2368:
URL: https://github.com/apache/bookkeeper/pull/2368#discussion_r447418133



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java
##########
@@ -180,6 +180,11 @@ public static short getFlags(int packetHeader) {
      */
     int ETOOMANYREQUESTS = 106;
 
+    /**
+     * Client could not be authenticated.
+     */
+    int EAUTH = 107;

Review comment:
       Why aren't you using existing code EUA (102)?
   If we use EUA this change is compatible with old clients seamlessly 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org