You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/04/25 22:15:54 UTC
Review Request 20730: Introduce operation_level request parameter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/
-----------------------------------------------------------
Review request for Ambari, Sumit Mohanty and Sid Wagle.
Bugs: AMBARI-5580
https://issues.apache.org/jira/browse/AMBARI-5580
Repository: ambari
Description
-------
Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level (specified at https://docs.google.com/a/hortonworks.com/document/d/1IB-2NGpLC3pb25S0FBI6L8PKaE24SMFqiJJKQHw9h8Q/edit#) from the list of available values, because it seems to be identical to SERVICE level.
This is a preview version of patch.
Patch seems to work, but unit test fixing/coverage is not finished yet
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Controller.py 9839313
ambari-agent/src/main/python/ambari_agent/security.py 9801dec
ambari-agent/src/test/python/ambari_agent/TestController.py daa7b82
ambari-agent/src/test/python/ambari_agent/TestSecurity.py d8955cf
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/State.java 835b751
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
ambari-server/src/main/resources/properties.json f92d238
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py 42a8610
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java 5fc66a6
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py f5148ff
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py d2a0390
ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 111d8b3
ambari-web/app/assets/test/tests.js 1ba5922
ambari-web/app/controllers/main/host/details.js 4dea285
ambari-web/app/controllers/main/jobs/hive_job_details_controller.js 1e2df7e
ambari-web/app/controllers/wizard/step9_controller.js 8494a87
ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 6222a88
ambari-web/app/router.js 73045d3
ambari-web/app/routes/installer.js deffe56
ambari-web/app/routes/main.js 9e00962
ambari-web/app/templates/wizard/step9.hbs 307609e
ambari-web/app/templates/wizard/step9/step9HostTasksLogPopup.hbs
ambari-web/app/templates/wizard/step9/step9_install_host_popup.hbs
ambari-web/app/views.js 6555313
ambari-web/app/views/main/service/info/metrics/flume/flume_metric_graphs.js 1ebfb60
ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js dd05b59
ambari-web/app/views/wizard/step9_view.js ec64530
ambari-web/test/installer/step9_test.js 2469828
ambari-web/test/views/wizard/step9/hostLogPopupBody_view_test.js 918d3d9
ambari-web/test/views/wizard/step9_view_test.js 733c3f9
Diff: https://reviews.apache.org/r/20730/diff/
Testing
-------
Patch seems to work, but unit test fixing/coverage is not finished yet
Thanks,
Dmitro Lisnichenko
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review42714
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On May 8, 2014, 7:56 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 7:56 p.m.)
>
>
> Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5580
> https://issues.apache.org/jira/browse/AMBARI-5580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 6c88429
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java d04dc26
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java c86c3ed
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f12299f
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
> ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
> ambari-server/src/main/resources/properties.json f92d238
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 2122a8b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20730/diff/
>
>
> Testing
> -------
>
> I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
> Result of unit test run attached.
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review42533
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On May 8, 2014, 7:56 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 7:56 p.m.)
>
>
> Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5580
> https://issues.apache.org/jira/browse/AMBARI-5580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 6c88429
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java d04dc26
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java c86c3ed
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f12299f
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
> ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
> ambari-server/src/main/resources/properties.json f92d238
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 2122a8b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20730/diff/
>
>
> Testing
> -------
>
> I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
> Result of unit test run attached.
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On May 12, 2014, 5:42 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java, line 69
> > <https://reviews.apache.org/r/20730/diff/6/?file=577041#file577041line69>
> >
> > Why is this required if not used ?
In some previous version of my patch, I was referencing to MaintenanceStateHelper.getEffectiveState() instead of DISABLED state. I've cut off this functionality from a current patch because it was not complete, but I'll reintroduce it in next jiras later.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review42713
-----------------------------------------------------------
On May 8, 2014, 7:56 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 7:56 p.m.)
>
>
> Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5580
> https://issues.apache.org/jira/browse/AMBARI-5580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 6c88429
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java d04dc26
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java c86c3ed
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f12299f
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
> ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
> ambari-server/src/main/resources/properties.json f92d238
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 2122a8b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20730/diff/
>
>
> Testing
> -------
>
> I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
> Result of unit test run attached.
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review42713
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
<https://reviews.apache.org/r/20730/#comment76524>
Why is this required if not used ?
- Sid Wagle
On May 8, 2014, 7:56 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 7:56 p.m.)
>
>
> Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5580
> https://issues.apache.org/jira/browse/AMBARI-5580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 6c88429
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java d04dc26
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java c86c3ed
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f12299f
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
> ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
> ambari-server/src/main/resources/properties.json f92d238
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 2122a8b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20730/diff/
>
>
> Testing
> -------
>
> I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
> Result of unit test run attached.
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/
-----------------------------------------------------------
(Updated May 8, 2014, 7:56 p.m.)
Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Changes
-------
Uploaded an updated patch. It fixes Nate's comments. Also, I've merged changes with latest trunk and moved DB upgrade to UpgradeCatalog161 because the fix version for this issue has been changed to 1.6.1.
Bugs: AMBARI-5580
https://issues.apache.org/jira/browse/AMBARI-5580
Repository: ambari
Description
-------
Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 6c88429
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java d04dc26
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java c86c3ed
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java PRE-CREATION
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f12299f
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
ambari-server/src/main/resources/properties.json f92d238
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 2122a8b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/20730/diff/
Testing
-------
I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
Result of unit test run attached.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.200s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
[INFO] Ambari Web ........................................ SUCCESS [6.233s]
[INFO] Ambari Views ...................................... SUCCESS [1.822s]
[INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
[INFO] Ambari Agent ...................................... SUCCESS [5.038s]
[INFO] Ambari Client ..................................... SUCCESS [0.360s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:13.873s
[INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
[INFO] Final Memory: 31M/360M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On May 5, 2014, 7:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java, lines 201-238
> > <https://reviews.apache.org/r/20730/diff/5/?file=570689#file570689line201>
> >
> > Maybe this can be a case statement on Resource.InternalType ?
It's a good idea.
> On May 5, 2014, 7:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java, lines 78-81
> > <https://reviews.apache.org/r/20730/diff/5/?file=570690#file570690line78>
> >
> > What is the purpose of keeping these with the level?
Sumit asked to do that for (possible) future use.
> On May 5, 2014, 7:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java, lines 230-258
> > <https://reviews.apache.org/r/20730/diff/5/?file=570691#file570691line230>
> >
> > Can a operation level be inferred from the resourceFilter if there is one? Is there a relationship that can be exploited? Seems odd to have a operational level that does also apply to a resourceFilter
We are going to use resource filter if operation level is not specified explicitly for the request (as a fallback logic). That is not implemented yet.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review42182
-----------------------------------------------------------
On May 5, 2014, 5:44 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 5:44 p.m.)
>
>
> Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5580
> https://issues.apache.org/jira/browse/AMBARI-5580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
> ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
> ambari-server/src/main/resources/properties.json f92d238
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
>
> Diff: https://reviews.apache.org/r/20730/diff/
>
>
> Testing
> -------
>
> I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
> Result of unit test run attached.
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review42182
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
<https://reviews.apache.org/r/20730/#comment75922>
Maybe this can be a case statement on Resource.InternalType ?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java
<https://reviews.apache.org/r/20730/#comment75936>
What is the purpose of keeping these with the level?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
<https://reviews.apache.org/r/20730/#comment75935>
Can a operation level be inferred from the resourceFilter if there is one? Is there a relationship that can be exploited? Seems odd to have a operational level that does also apply to a resourceFilter
- Nate Cole
On May 5, 2014, 1:44 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 1:44 p.m.)
>
>
> Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5580
> https://issues.apache.org/jira/browse/AMBARI-5580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
> ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
> ambari-server/src/main/resources/properties.json f92d238
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
>
> Diff: https://reviews.apache.org/r/20730/diff/
>
>
> Testing
> -------
>
> I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
> Result of unit test run attached.
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/
-----------------------------------------------------------
(Updated May 5, 2014, 5:44 p.m.)
Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-5580
https://issues.apache.org/jira/browse/AMBARI-5580
Repository: ambari
Description
-------
Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
ambari-server/src/main/resources/properties.json f92d238
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
Diff: https://reviews.apache.org/r/20730/diff/
Testing
-------
I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
Result of unit test run attached.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.200s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
[INFO] Ambari Web ........................................ SUCCESS [6.233s]
[INFO] Ambari Views ...................................... SUCCESS [1.822s]
[INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
[INFO] Ambari Agent ...................................... SUCCESS [5.038s]
[INFO] Ambari Client ..................................... SUCCESS [0.360s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:13.873s
[INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
[INFO] Final Memory: 31M/360M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review41817
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On April 29, 2014, 3:20 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 3:20 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5580
> https://issues.apache.org/jira/browse/AMBARI-5580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
> ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
> ambari-server/src/main/resources/properties.json f92d238
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
>
> Diff: https://reviews.apache.org/r/20730/diff/
>
>
> Testing
> -------
>
> I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
> Result of unit test run attached.
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/
-----------------------------------------------------------
(Updated April 29, 2014, 3:20 p.m.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Changes
-------
Fixed issues with Oracle DB
Bugs: AMBARI-5580
https://issues.apache.org/jira/browse/AMBARI-5580
Repository: ambari
Description
-------
Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
ambari-server/src/main/resources/properties.json f92d238
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
Diff: https://reviews.apache.org/r/20730/diff/
Testing (updated)
-------
I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
Result of unit test run attached.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.200s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
[INFO] Ambari Web ........................................ SUCCESS [6.233s]
[INFO] Ambari Views ...................................... SUCCESS [1.822s]
[INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
[INFO] Ambari Agent ...................................... SUCCESS [5.038s]
[INFO] Ambari Client ..................................... SUCCESS [0.360s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:13.873s
[INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
[INFO] Final Memory: 31M/360M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/
-----------------------------------------------------------
(Updated April 29, 2014, 8:57 a.m.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Changes
-------
removed unused code
Bugs: AMBARI-5580
https://issues.apache.org/jira/browse/AMBARI-5580
Repository: ambari
Description
-------
Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
ambari-server/src/main/resources/properties.json f92d238
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
Diff: https://reviews.apache.org/r/20730/diff/
Testing
-------
Patch seems to work, also I'm performing manual testing in various scenarios (Mysql/Oracle DB, upgrade from 1.5.x).
Result of unit test run attached.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.200s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
[INFO] Ambari Web ........................................ SUCCESS [6.233s]
[INFO] Ambari Views ...................................... SUCCESS [1.822s]
[INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
[INFO] Ambari Agent ...................................... SUCCESS [5.038s]
[INFO] Ambari Client ..................................... SUCCESS [0.360s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:13.873s
[INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
[INFO] Final Memory: 31M/360M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/
-----------------------------------------------------------
(Updated April 29, 2014, 8:55 a.m.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-5580
https://issues.apache.org/jira/browse/AMBARI-5580
Repository: ambari
Description (updated)
-------
Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
ambari-server/src/main/resources/properties.json f92d238
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
Diff: https://reviews.apache.org/r/20730/diff/
Testing
-------
Patch seems to work, also I'm performing manual testing in various scenarios (Mysql/Oracle DB, upgrade from 1.5.x).
Result of unit test run attached.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.200s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
[INFO] Ambari Web ........................................ SUCCESS [6.233s]
[INFO] Ambari Views ...................................... SUCCESS [1.822s]
[INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
[INFO] Ambari Agent ...................................... SUCCESS [5.038s]
[INFO] Ambari Client ..................................... SUCCESS [0.360s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:13.873s
[INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
[INFO] Final Memory: 31M/360M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On April 28, 2014, 9:42 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java, line 430
> > <https://reviews.apache.org/r/20730/diff/3/?file=569631#file569631line430>
> >
> > This should be deleted if unused. Any reason for this to stick around ?
I was going to remove it with commit for next jira. Will delete it.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review41640
-----------------------------------------------------------
On April 28, 2014, 8:35 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 8:35 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
>
>
> Bugs: AMBARI-5580
> https://issues.apache.org/jira/browse/AMBARI-5580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level (specified at https://docs.google.com/a/hortonworks.com/document/d/1IB-2NGpLC3pb25S0FBI6L8PKaE24SMFqiJJKQHw9h8Q/edit#) from the list of available values, because it seems to be identical to SERVICE level.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
> ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
> ambari-server/src/main/resources/properties.json f92d238
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
>
> Diff: https://reviews.apache.org/r/20730/diff/
>
>
> Testing
> -------
>
> Patch seems to work, also I'm performing manual testing in various scenarios (Mysql/Oracle DB, upgrade from 1.5.x).
> Result of unit test run attached.
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review41640
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
<https://reviews.apache.org/r/20730/#comment75192>
This should be deleted if unused. Any reason for this to stick around ?
- Sid Wagle
On April 28, 2014, 8:35 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 8:35 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
>
>
> Bugs: AMBARI-5580
> https://issues.apache.org/jira/browse/AMBARI-5580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level (specified at https://docs.google.com/a/hortonworks.com/document/d/1IB-2NGpLC3pb25S0FBI6L8PKaE24SMFqiJJKQHw9h8Q/edit#) from the list of available values, because it seems to be identical to SERVICE level.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
> ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
> ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
> ambari-server/src/main/resources/properties.json f92d238
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
>
> Diff: https://reviews.apache.org/r/20730/diff/
>
>
> Testing
> -------
>
> Patch seems to work, also I'm performing manual testing in various scenarios (Mysql/Oracle DB, upgrade from 1.5.x).
> Result of unit test run attached.
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/
-----------------------------------------------------------
(Updated April 28, 2014, 8:35 p.m.)
Review request for Ambari, Sumit Mohanty and Sid Wagle.
Changes
-------
Uploaded a (hopefully) final patch.
Bugs: AMBARI-5580
https://issues.apache.org/jira/browse/AMBARI-5580
Repository: ambari
Description (updated)
-------
Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level (specified at https://docs.google.com/a/hortonworks.com/document/d/1IB-2NGpLC3pb25S0FBI6L8PKaE24SMFqiJJKQHw9h8Q/edit#) from the list of available values, because it seems to be identical to SERVICE level.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
ambari-server/src/main/resources/properties.json f92d238
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
Diff: https://reviews.apache.org/r/20730/diff/
Testing (updated)
-------
Patch seems to work, also I'm performing manual testing in various scenarios (Mysql/Oracle DB, upgrade from 1.5.x).
Result of unit test run attached.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.200s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
[INFO] Ambari Web ........................................ SUCCESS [6.233s]
[INFO] Ambari Views ...................................... SUCCESS [1.822s]
[INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
[INFO] Ambari Agent ...................................... SUCCESS [5.038s]
[INFO] Ambari Client ..................................... SUCCESS [0.360s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:13.873s
[INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
[INFO] Final Memory: 31M/360M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 20730: Introduce operation_level request parameter
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/
-----------------------------------------------------------
(Updated April 25, 2014, 8:22 p.m.)
Review request for Ambari, Sumit Mohanty and Sid Wagle.
Bugs: AMBARI-5580
https://issues.apache.org/jira/browse/AMBARI-5580
Repository: ambari
Description
-------
Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level (specified at https://docs.google.com/a/hortonworks.com/document/d/1IB-2NGpLC3pb25S0FBI6L8PKaE24SMFqiJJKQHw9h8Q/edit#) from the list of available values, because it seems to be identical to SERVICE level.
This is a preview version of patch.
Patch seems to work, but unit test fixing/coverage is not finished yet
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/State.java 835b751
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579
ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2
ambari-server/src/main/resources/properties.json f92d238
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a
ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java 5fc66a6
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b
Diff: https://reviews.apache.org/r/20730/diff/
Testing
-------
Patch seems to work, but unit test fixing/coverage is not finished yet
Thanks,
Dmitro Lisnichenko