You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hivemall.apache.org by maropu <gi...@git.apache.org> on 2017/01/25 10:08:50 UTC

[GitHub] incubator-hivemall pull request #25: [HIVEMALL-34] Fix a bug to wrongly use ...

GitHub user maropu opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/25

    [HIVEMALL-34] Fix a bug to wrongly use mllib vectors in some functions

    ## What changes were proposed in this pull request?
    In `to_hivemall_features` and `append_bias` in `HivemallUtils`, they wrongly used mllib vectors. They should use ml vectors instead.
    
    ## What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/HIVEMALL-34
    
    ## How was this patch tested?
    Enabled a test in `HiveUdfWithVectorSuite`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maropu/incubator-hivemall HIVEMALL-34

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit d1c8b64176fd6caf9f2f00a51017ccce40df6eb9
Author: Takeshi YAMAMURO <li...@gmail.com>
Date:   2017-01-25T10:06:02Z

    Fix a bug to wrongly use mllib vectors in some functions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #25: [HIVEMALL-34] Fix a bug to wrongly use mllib v...

Posted by maropu <gi...@git.apache.org>.

Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/25
  
    Merged!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #25: [HIVEMALL-34] Fix a bug to wrongly use ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hivemall/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #25: [HIVEMALL-34] Fix a bug to wrongly use mllib v...

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/25
  
    
    [![Coverage Status](https://coveralls.io/builds/9838317/badge)](https://coveralls.io/builds/9838317)
    
    Coverage increased (+0.3%) to 36.14% when pulling **186155c1579a2ba53017177be7f1d5bb5e5137bb on maropu:HIVEMALL-34** into **4688494418693de5b08dc0a4bd22685dbcf0b876 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #25: [HIVEMALL-34] Fix a bug to wrongly use mllib v...

Posted by myui <gi...@git.apache.org>.

Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/25
  
    @maropu LGTM. Please merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---