You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "kerwin-zk (via GitHub)" <gi...@apache.org> on 2024/02/19 01:58:21 UTC
[PR] [CELEBORN-1265][FOLLOWUP] Fix batches read metric for gluten columnar shuffle [incubator-celeborn]
kerwin-zk opened a new pull request, #2301:
URL: https://github.com/apache/incubator-celeborn/pull/2301
### What changes were proposed in this pull request?
Remove an unused class.
### Why are the changes needed?
#2289
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1265][FOLLOWUP] Fix batches read metric for gluten columnar shuffle [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2301:
URL: https://github.com/apache/incubator-celeborn/pull/2301#issuecomment-1951576688
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`3f5b1de`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/3f5b1de759ff0784c580029ff537a9e2057fdcf3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.94% compared to head [(`147d8ef`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.05%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2301 +/- ##
==========================================
+ Coverage 48.94% 49.05% +0.12%
==========================================
Files 208 208
Lines 12893 12893
Branches 1113 1113
==========================================
+ Hits 6309 6324 +15
+ Misses 6176 6163 -13
+ Partials 408 406 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1265][FOLLOWUP] Remove unnecessary GlutenShuffleDependencyHelper [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2301:
URL: https://github.com/apache/incubator-celeborn/pull/2301#issuecomment-1953575374
Merged to main(v0.5.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1265][FOLLOWUP] Fix batches read metric for gluten columnar shuffle [incubator-celeborn]
Posted by "kerwin-zk (via GitHub)" <gi...@apache.org>.
kerwin-zk commented on PR #2301:
URL: https://github.com/apache/incubator-celeborn/pull/2301#issuecomment-1951567083
@AngersZhuuuu cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1265][FOLLOWUP] Remove unnecessary GlutenShuffleDependencyHelper [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2301: [CELEBORN-1265][FOLLOWUP] Remove unnecessary GlutenShuffleDependencyHelper
URL: https://github.com/apache/incubator-celeborn/pull/2301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org