You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Josef Cacek <no...@github.com> on 2016/05/24 17:59:20 UTC
[jclouds/jclouds-labs] JCLOUDS-1117 & JCLOUDS-1118 - docker container
configuration fixes (#274)
JIRAs:
* https://issues.apache.org/jira/browse/JCLOUDS-1117
* https://issues.apache.org/jira/browse/JCLOUDS-1118
This pull request contains Docker configuration fixes.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/274
-- Commit Summary --
* [JCLOUDS-1117] fix for advanced Docker configuration - the Config.Builder should stay unchanged if used
* [JCLOUDS-1118] fix configuration options location; mark some fields Nullable
-- File Changes --
M docker/src/main/java/org/jclouds/docker/compute/strategy/DockerComputeServiceAdapter.java (70)
M docker/src/main/java/org/jclouds/docker/domain/Config.java (120)
M docker/src/main/java/org/jclouds/docker/domain/HostConfig.java (51)
M docker/src/main/java/org/jclouds/docker/domain/Info.java (4)
M docker/src/test/java/org/jclouds/docker/compute/SshToCustomPortLiveTest.java (14)
M docker/src/test/java/org/jclouds/docker/domain/ConfigTest.java (3)
M docker/src/test/java/org/jclouds/docker/features/ContainerApiLiveTest.java (5)
M docker/src/test/java/org/jclouds/docker/parse/ContainerParseTest.java (3)
A docker/src/test/java/org/jclouds/docker/parse/Info2ParseTest.java (72)
M docker/src/test/resources/container.json (7)
A docker/src/test/resources/info2.json (90)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/274.patch
https://github.com/jclouds/jclouds-labs/pull/274.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/274
Re: [jclouds/jclouds-labs] JCLOUDS-1117 & JCLOUDS-1118 - docker
container configuration fixes (#274)
Posted by Josef Cacek <no...@github.com>.
As I look into it, I've probably forgot to add some fields to `HostConfig`. I'll fix it and try to add some more test coverage.
So don't merge this yet, please.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/274#issuecomment-221490444
Re: [jclouds/jclouds-labs] JCLOUDS-1117 & JCLOUDS-1118 - docker
container configuration fixes (#274)
Posted by Ignasi Barrera <no...@github.com>.
Squashed the last commit into the second one and pushed to master as [c269e016](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c269e016) and [6d078e69](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6d078e69). Thanks @kwart!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/274#issuecomment-221833652
Re: [jclouds/jclouds-labs] JCLOUDS-1117 & JCLOUDS-1118 - docker
container configuration fixes (#274)
Posted by Ignasi Barrera <no...@github.com>.
Closed #274.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/274#event-672973892
Re: [jclouds/jclouds-labs] JCLOUDS-1117 & JCLOUDS-1118 - docker
container configuration fixes (#274)
Posted by Josef Cacek <no...@github.com>.
I've re-checked the fields and there was nothing forgotten.
Nevertheless I've added test coverage for Container parsing for Docker Remote API version 1.21 and I discovered missing `Nullable` annotation by 2 fields.
The new tests and fixes are in a new commit. I can squash it to the previous (2nd) one.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/274#issuecomment-221733009
Re: [jclouds/jclouds-labs] JCLOUDS-1117 & JCLOUDS-1118 - docker
container configuration fixes (#274)
Posted by Ignasi Barrera <no...@github.com>.
Thanks @kwart! Looks good to me. @andreaturli @grkvlt want to have a look?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/274#issuecomment-221401341