You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/25 05:33:04 UTC
[PR] fix(studio): preserve instance context on discovery failure [rocketmq-dashboard]
Aias00 opened a new pull request, #2567:
URL: https://github.com/apache/rocketmq-dashboard/pull/2567
## Summary
- retain the instance encoded in an instance-scoped route when the shared inventory request fails, instead of changing the selected instance to `undefined`
- expose inventory error and retry state from `useInstanceFilter` for the shared Topic, Consumer, Message, ACL, and DLQ consumers
- treat unknown or failed instance capabilities as unavailable for capability-gated navigation, while retaining global navigation when no instance is selected
- add regression coverage for inventory failure, retry, and capability discovery failure
## Why
A temporary instance-list failure previously disabled data loading across all instance-scoped pages despite a route already carrying an instance ID. Separately, a capability-query failure made every capability-gated operation appear available, allowing navigation into provider operations that could only fail later with a 501 response.
## Validation
- `npm test -- --run src/hooks/useInstanceFilter.test.tsx src/layouts/MainLayout.test.tsx`
- `npx eslint src/hooks/useInstanceFilter.ts src/hooks/useInstanceFilter.test.tsx src/layouts/MainLayout.tsx src/layouts/MainLayout.test.tsx --max-warnings=0`
- `npm run build`
- `git diff --check`
Closes #2566.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(studio): preserve instance context on discovery failure [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2567:
URL: https://github.com/apache/rocketmq-dashboard/pull/2567#issuecomment-5502380682
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(studio): preserve instance context on discovery failure [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2567: fix(studio): preserve instance context on discovery failure
URL: https://github.com/apache/rocketmq-dashboard/pull/2567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org