You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/06/06 02:02:34 UTC
Review Request 35165: Extend fq_codel to allow parent and handle to be
specified at runtime.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35165/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs: MESOS-2332
https://issues.apache.org/jira/browse/MESOS-2332
Repository: mesos
Description
-------
Extend fq_codel to allow parent and handle to be specified at runtime.
Diffs
-----
src/linux/routing/queueing/fq_codel.hpp 412af2d7da2c70324234ee75df75c71319b1365a
src/linux/routing/queueing/fq_codel.cpp 3db5b9390bb5ae759eb1b7c9d1ac87cfca8d531e
src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
src/tests/routing_tests.cpp db5b5df48634ff322baf9328fc605b2667b56eed
Diff: https://reviews.apache.org/r/35165/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 35165: Extend fq_codel to allow parent and handle
to be specified at runtime.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35165/#review87050
-----------------------------------------------------------
Ship it!
src/linux/routing/queueing/fq_codel.hpp
<https://reviews.apache.org/r/35165/#comment139319>
Can you make this optional?
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35165/#comment139313>
Do we use this?
- Jie Yu
On June 6, 2015, 12:02 a.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35165/
> -----------------------------------------------------------
>
> (Updated June 6, 2015, 12:02 a.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2332
> https://issues.apache.org/jira/browse/MESOS-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extend fq_codel to allow parent and handle to be specified at runtime.
>
>
> Diffs
> -----
>
> src/linux/routing/queueing/fq_codel.hpp 412af2d7da2c70324234ee75df75c71319b1365a
> src/linux/routing/queueing/fq_codel.cpp 3db5b9390bb5ae759eb1b7c9d1ac87cfca8d531e
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
> src/tests/routing_tests.cpp db5b5df48634ff322baf9328fc605b2667b56eed
>
> Diff: https://reviews.apache.org/r/35165/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35165: Extend fq_codel to allow parent and handle
to be specified at runtime.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35165/#review86894
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35150, 35152, 35165]
All tests passed.
- Mesos ReviewBot
On June 6, 2015, 12:02 a.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35165/
> -----------------------------------------------------------
>
> (Updated June 6, 2015, 12:02 a.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2332
> https://issues.apache.org/jira/browse/MESOS-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extend fq_codel to allow parent and handle to be specified at runtime.
>
>
> Diffs
> -----
>
> src/linux/routing/queueing/fq_codel.hpp 412af2d7da2c70324234ee75df75c71319b1365a
> src/linux/routing/queueing/fq_codel.cpp 3db5b9390bb5ae759eb1b7c9d1ac87cfca8d531e
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
> src/tests/routing_tests.cpp db5b5df48634ff322baf9328fc605b2667b56eed
>
> Diff: https://reviews.apache.org/r/35165/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35165: Extend fq_codel to allow parent and handle
to be specified at runtime.
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35165/
-----------------------------------------------------------
(Updated June 8, 2015, 8:47 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Changes
-------
Address review comments.
Bugs: MESOS-2332
https://issues.apache.org/jira/browse/MESOS-2332
Repository: mesos
Description
-------
Extend fq_codel to allow parent and handle to be specified at runtime.
Diffs (updated)
-----
src/linux/routing/queueing/fq_codel.hpp 412af2d7da2c70324234ee75df75c71319b1365a
src/linux/routing/queueing/fq_codel.cpp 3db5b9390bb5ae759eb1b7c9d1ac87cfca8d531e
src/slave/containerizer/isolators/network/port_mapping.cpp df2de601a883f4643d632204fdb7b779668a377a
src/tests/routing_tests.cpp db5b5df48634ff322baf9328fc605b2667b56eed
Diff: https://reviews.apache.org/r/35165/diff/
Testing
-------
make check
Thanks,
Paul Brett