You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/22 08:57:54 UTC
[GitHub] sunjincheng121 commented on a change in pull request #7159:
[FLINK-10983][queryable state] Increase port range for
NonHAQueryableStateFsBackendITCase
sunjincheng121 commented on a change in pull request #7159: [FLINK-10983][queryable state] Increase port range for NonHAQueryableStateFsBackendITCase
URL: https://github.com/apache/flink/pull/7159#discussion_r235643622
##########
File path: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/NonHAQueryableStateFsBackendITCase.java
##########
@@ -86,10 +86,10 @@ private static Configuration getConfig() {
config.setInteger(QueryableStateOptions.SERVER_NETWORK_THREADS, 1);
config.setString(
QueryableStateOptions.PROXY_PORT_RANGE,
- QS_PROXY_PORT_RANGE_START + "-" + (QS_PROXY_PORT_RANGE_START + NUM_TMS));
+ QS_PROXY_PORT_RANGE_START + "-" + (QS_PROXY_PORT_RANGE_START + 100));
config.setString(
QueryableStateOptions.SERVER_PORT_RANGE,
- QS_SERVER_PORT_RANGE_START + "-" + (QS_SERVER_PORT_RANGE_START + NUM_TMS));
+ QS_SERVER_PORT_RANGE_START + "-" + (QS_SERVER_PORT_RANGE_START + 100));
Review comment:
I think 100 is enough, just a suggestion: add a static variableļ¼ such as: `private static final int NUM_PORT_COUNT = 128;` What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services