You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/13 03:13:41 UTC

[GitHub] [kylin] hit-lacus commented on a change in pull request #1054: Fix some insecure issues

hit-lacus commented on a change in pull request #1054: Fix some insecure issues
URL: https://github.com/apache/kylin/pull/1054#discussion_r365637008
 
 

 ##########
 File path: server/src/test/java/org/apache/kylin/rest/util/ValidateUtilTest.java
 ##########
 @@ -48,6 +48,9 @@
 
     @Test
     public void testCheckIdentifiersExists() throws IOException {
+        String project = "/asd/../_asd33b";
+        project = ValidateUtil.convertStringToBeAlphanumericUnderscore(project);
 
 Review comment:
   Could we add some assertEqual for this `project`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services