[GitHub] [superset] hughhhh commented on a change in pull request #19289: feat: Implements Docusearch into docusaurus docs

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #19289:
URL: https://github.com/apache/superset/pull/19289#discussion_r831479886



##########
File path: docs/docusaurus.config.js
##########
@@ -159,6 +157,11 @@ const config = {
         defaultMode: 'light',
         disableSwitch: true,
       },
+      algolia: {
+        appId: 'WR5FASX5ED',
+        apiKey: '299e4601d2fc5d0031bf9a0223c7f0c5',

Review comment:
       is there a way for us to embedded these keys via the env? Personally don't think it is a good idea to just have these available for someone to just copy




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org