You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/13 01:02:56 UTC

[kudu-CR] Remove a spurious warning left in raft consensus state.cc 

Hello Mike Percy,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4391

to review the following change.

Change subject: Remove a spurious warning left in raft_consensus_state.cc
......................................................................

Remove a spurious warning left in raft_consensus_state.cc

Change-Id: I0bcada22bc31e1640e5e047c2326f61dc617705d
---
M src/kudu/consensus/raft_consensus_state.cc
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/4391/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bcada22bc31e1640e5e047c2326f61dc617705d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Remove a spurious warning left in raft consensus state.cc

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Remove a spurious warning left in raft_consensus_state.cc
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3384/

-- 
To view, visit http://gerrit.cloudera.org:8080/4391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcada22bc31e1640e5e047c2326f61dc617705d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Remove a spurious warning left in raft consensus state.cc

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Remove a spurious warning left in raft_consensus_state.cc
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcada22bc31e1640e5e047c2326f61dc617705d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Remove a spurious warning left in raft consensus state.cc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Remove a spurious warning left in raft_consensus_state.cc
......................................................................


Remove a spurious warning left in raft_consensus_state.cc

Change-Id: I0bcada22bc31e1640e5e047c2326f61dc617705d
Reviewed-on: http://gerrit.cloudera.org:8080/4391
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/raft_consensus_state.cc
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0bcada22bc31e1640e5e047c2326f61dc617705d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>