[GitHub] [trafficcontrol] shamrickus commented on pull request #5817: Traffic Monitor Integration Test Framework

[GitBox <gi...@apache.org>]

shamrickus commented on pull request #5817:
URL: https://github.com/apache/trafficcontrol/pull/5817#issuecomment-839973182


   > A lot of the TM integration test Docker environment seems to be copied from an older version of CDN in a Box.
   > I can understand only wanting to build and use the pieces that are relevant for the TM integration tests, but using CDN in a Box where it sits instead of copying it does not require starting everything. For example, neither the TO integration tests nor the TP integration tests require starting all of the CDN in a Box services:
   > 
   > https://github.com/apache/trafficcontrol/blob/55dbb7eacd399d3ccef9d4eb34bfaeb0c5e2e7ad/infrastructure/cdn-in-a-box/docker-compose.traffic-ops-test.yml#L23-L24
   > 
   > https://github.com/apache/trafficcontrol/blob/55dbb7eacd399d3ccef9d4eb34bfaeb0c5e2e7ad/infrastructure/cdn-in-a-box/docker-compose.traffic-portal-test.yml#L23-L24
   
   I agree it'd be better for that, but I was going off of what Rob already did. I figured it would be more valuable to get this merged and working, and then later down the road it can be moved to CiaB (testcaches would also need to be ported). That also has the added benefit of building and running this currently only takes about as long as it does to build just TM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org