You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/10/02 23:49:00 UTC

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

    [ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206564#comment-17206564 ] 

Hudson commented on HBASE-24492:
--------------------------------

Results for branch branch-2.3
	[build #69 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69//console].


> ProtobufLogReader.readNext does not need looping
> ------------------------------------------------
>
>                 Key: HBASE-24492
>                 URL: https://issues.apache.org/jira/browse/HBASE-24492
>             Project: HBase
>          Issue Type: Task
>          Components: Replication, wal
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method, however it returns value or throws errors in single execution. while(true) was part of initial code and with better improvements in the method, this loop has not been removed yet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)