You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2006/04/05 18:05:59 UTC
[jira] Resolved: (SM-384) In
org.apache.servicemix.jbi.messaging.NormalizedMessageImpl, it appears that
the getters and setters are innappropriately synchronized
[ https://issues.apache.org/activemq/browse/SM-384?page=all ]
Guillaume Nodet resolved SM-384:
--------------------------------
Fix Version: 3.0-M1
Resolution: Fixed
Assign To: Guillaume Nodet
There is really no reason why the same exchange would be accessed by more than one thread.
Author: gnodet
Date: Wed Apr 5 09:04:07 2006
New Revision: 391659
URL: http://svn.apache.org/viewcvs?rev=391659&view=rev
Log:
SM-384: getters and setters are inappropriately synchronized on NormalizedMessageImpl and MessageExchangeImpl
Modified:
incubator/servicemix/trunk/servicemix-core/src/main/java/org/apache/servicemix/jbi/messaging/MessageExchangeImpl.java
incubator/servicemix/trunk/servicemix-core/src/main/java/org/apache/servicemix/jbi/messaging/NormalizedMessageImpl.java
> In org.apache.servicemix.jbi.messaging.NormalizedMessageImpl, it appears that the getters and setters are innappropriately synchronized
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SM-384
> URL: https://issues.apache.org/activemq/browse/SM-384
> Project: ServiceMix
> Type: Improvement
> Components: servicemix-core
> Versions: 3.0
> Reporter: Jeff Puro
> Assignee: Guillaume Nodet
> Fix For: 3.0-M1
>
>
> It's possible that we do not need to synchronize the getters and setters of the NormalizedMessageImpl class. Removing these synchronizations should increase performance when manipulating messages. Whoever authored this class should be consulted as to the reasons behind doing this. Are we worried about multiple threads accessing the same normalized message? The only time I see this happening is if a component spawns multiple threads working on the same NormalizedMessage, but even in this case we could use a wrapper class that synchronizes the necessary methods. Perhaps there is something in the core library of servicemix that needs these synchronized?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira