You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by pe...@apache.org on 2006/08/31 23:42:22 UTC
svn commit: r439055 - in /ant/core/trunk: WHATSNEW
src/main/org/apache/tools/ant/Target.java
Author: peterreilly
Date: Thu Aug 31 14:42:21 2006
New Revision: 439055
URL: http://svn.apache.org/viewvc?rev=439055&view=rev
Log:
remove equals/hashcode from Target. Bugzilla report 40207.
Modified:
ant/core/trunk/WHATSNEW
ant/core/trunk/src/main/org/apache/tools/ant/Target.java
Modified: ant/core/trunk/WHATSNEW
URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=439055&r1=439054&r2=439055&view=diff
==============================================================================
--- ant/core/trunk/WHATSNEW (original)
+++ ant/core/trunk/WHATSNEW Thu Aug 31 14:42:21 2006
@@ -8,6 +8,8 @@
-----------
* <zip filesonly="true"> included empty directories. Bugzilla report 40258.
+* Invalid hash code of Target causes XmlLogger to fail.
+ Bugzilla report 40207.
Other changes:
--------------
Modified: ant/core/trunk/src/main/org/apache/tools/ant/Target.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/Target.java?rev=439055&r1=439054&r2=439055&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/Target.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/Target.java Thu Aug 31 14:42:21 2006
@@ -454,28 +454,4 @@
String test = project.replaceProperties(unlessCondition);
return project.getProperty(test) == null;
}
-
- /**
- * Equality check is based on target name
- * @param that other thing to check
- * @return true iff type and name are equal
- */
- public boolean equals(Object that) {
- if (this == that) return true;
- if (that == null || getClass() != that.getClass()) return false;
-
- final Target target = (Target) that;
-
- if (name != null ? !name.equals(target.name) : target.name != null) return false;
-
- return true;
- }
-
- /**
- * Hash code is based on name, is 0 if the name==null
- * @return hash code
- */
- public int hashCode() {
- return (name != null ? name.hashCode() : 0);
- }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org