You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/10/13 14:37:07 UTC

[GitHub] flink pull request #4824: [FLINK-7648] [flip6] Add TaskManagersHandler

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4824

    [FLINK-7648] [flip6] Add TaskManagersHandler

    ## What is the purpose of the change
    
    Add the `TaskManagersHandler` for the new REST server endpoint.
    
    ## Brief change log
    
    - Added `TaskManagersHandler` and `TaskManagersHeaders` for serving `TaskManagersInfo`
    - Changed the serialization of the `legacy.TaskManagersHandler` to reflect `TaskManagerInfo` serialization where the `HardwareDescription` is stored in a nested JSON object.
    
    ## Verifying this change
    
    Added tests:
    
    - `TaskManagerInfoTest` and `TaskManagersInfoTest` for (un)marshalling
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink addTaskManagersHandler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4824.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4824
    
----
commit 77ece83513d9a79f2f0c3e7024d91243026c334c
Author: Till <ti...@gmail.com>
Date:   2017-10-13T07:19:51Z

    [FLINK-7832] [flip6] Extend SlotManager to report free slots per TM
    
    Fail if slot belongs to a unregistered TaskManager
    
    Add more sanity checks
    
    Make the TaskManagerSlot state transitions clearer
    
    Introduce proper TaskManagerSlot state enum
    
    Refactor SlotManager for better maintainability

commit 72ae21be368fc3de32a12e486c73a4fb69a76abf
Author: Till <ti...@gmail.com>
Date:   2017-10-12T16:24:02Z

    [FLINK-7831] Make last received heartbeat retrievable
    
    This commit adds functionality to retrieve the last received heartbeat from
    the HeartbeatManager.

commit fceae2d4fa1bda55f2f9b412388606747e9b24af
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-10-11T22:40:17Z

    [FLINK-7648] [flip6] Add TaskManagersHandler
    
    Send dataPort and HardwareDescription to RM
    
    Instantiate RM leader retriever

commit c7f637da68d9627b6dcc73ac4a88d278d7b4b5b5
Author: Till <ti...@gmail.com>
Date:   2017-10-13T14:32:56Z

    [FLINK-7648] [flip6] Write HardwareDescription in sub object of legacy.TaskManagersHandler

----


---

[GitHub] flink issue #4824: [FLINK-7648] [flip6] Add TaskManagersHandler

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4824
  
    Thanks for your review @zentol. Once the preceding PR are merged, I'll merge this one as well.


---

[GitHub] flink issue #4824: [FLINK-7648] [flip6] Add TaskManagersHandler

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4824
  
    The handler related commits look good to me.


---

[GitHub] flink pull request #4824: [FLINK-7648] [flip6] Add TaskManagersHandler

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4824


---