[GitHub] [incubator-pegasus] neverchanje commented on a change in pull request #593: fix: Use default options to open db when latest option file has uncompatible db options

[GitBox <gi...@apache.org>]

neverchanje commented on a change in pull request #593:
URL: https://github.com/apache/incubator-pegasus/pull/593#discussion_r483347124



##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -1330,9 +1330,18 @@ ::dsn::error_code pegasus_server_impl::start(int argc, char **argv)
     // Here we create a `tmp_data_cf_opts` because we don't want to modify `_data_cf_opts`, which
     // will be used elsewhere.
     rocksdb::ColumnFamilyOptions tmp_data_cf_opts = _data_cf_opts;
+    bool has_uncompatible_db_options = false;

Review comment:
       `uncompatible` is misspelled. The correct one is `incompatible`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org