You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/16 17:19:00 UTC

[jira] [Commented] (AIRFLOW-3529) Create the ability to test the kubernetes executor on an existing cluster

    [ https://issues.apache.org/jira/browse/AIRFLOW-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722530#comment-16722530 ] 

ASF GitHub Bot commented on AIRFLOW-3529:
-----------------------------------------

dimberman opened a new pull request #4326: [WIP][AIRFLOW-3529] Simplify k8s executor testing process.
URL: https://github.com/apache/incubator-airflow/pull/4326
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3529
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   Currently all integration testing for the kubernetes executor takes place on minikube. This is simultaneously a lot slower and not accurate to real-world use-cases. This PR will create a one-step script to run on a real k8s cluster and write documentation for easier onboarding.
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Create the ability to test the kubernetes executor on an existing cluster
> -------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3529
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3529
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: kubernetes
>            Reporter: Daniel Imberman
>            Assignee: Daniel Imberman
>            Priority: Major
>
> Currently all integration testing for the kubernetes executor takes place on minikube. This is simultaneously a lot slower and not accurate to real-world use-cases. This PR will create a one-step script to run on a real k8s cluster and write documentation for easier onboarding.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)