You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/07 17:52:16 UTC

[GitHub] [airflow] FloChehab opened a new pull request #12164: Support creation of configmaps & secrets and extra env & envFrom configuration

FloChehab opened a new pull request #12164:
URL: https://github.com/apache/airflow/pull/12164


   Hello,
   
   Here is a followup PR for what I was describing in https://github.com/apache/airflow/pull/10584#issuecomment-715530418.
   
   This adds support for:
   
   * Creating configMaps and secrets from the chart itself ; this can be used for https://github.com/apache/airflow/issues/11707 (especially connections values that should end up in a secret) and maybe other use cases.
   * Adding extra `env` and `envFrom` items to the airflow containers created by the chart (strictly independent from `extraSecrets` / `extraConfigMaps`).
   
   The values are of type string to enable for generic templating.
   
   More information can be found in the commits messages.
   
   Closes #10584
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] FloChehab commented on pull request #12164: Support creation of configmaps & secrets and extra env & envFrom configuration in Helm Chart

Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #12164:
URL: https://github.com/apache/airflow/pull/12164#issuecomment-728784093


   > Some static checks are failing though :)
   
   I've rebased on master and fixed the style issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #12164: Support creation of configmaps & secrets and extra env & envFrom configuration in Helm Chart

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12164:
URL: https://github.com/apache/airflow/pull/12164#issuecomment-727881478


   The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #12164: Support creation of configmaps & secrets and extra env & envFrom configuration in Helm Chart

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12164:
URL: https://github.com/apache/airflow/pull/12164


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #12164: Support creation of configmaps & secrets and extra env & envFrom configuration in Helm Chart

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12164:
URL: https://github.com/apache/airflow/pull/12164#issuecomment-728794136


   Cool!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #12164: Support creation of configmaps & secrets and extra env & envFrom configuration in Helm Chart

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12164:
URL: https://github.com/apache/airflow/pull/12164#issuecomment-727888198


   Some static checks are failing though :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] FloChehab commented on pull request #12164: Support creation of configmaps & secrets and extra env & envFrom configuration in Helm Chart

Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #12164:
URL: https://github.com/apache/airflow/pull/12164#issuecomment-727913853


   > Some static checks are failing though :)
   
   I'll fix that soon, I was waiting for some feedback first before investing more into this PR :D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #12164: Support creation of configmaps & secrets and extra env & envFrom configuration in Helm Chart

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12164:
URL: https://github.com/apache/airflow/pull/12164#issuecomment-723477180


   [The Workflow run](https://github.com/apache/airflow/actions/runs/351373741) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org