You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/07/12 09:15:49 UTC

[jira] [Commented] (WW-4122) Wasted work in AnnotationParameterFilterIntereptor.intercept()

    [ https://issues.apache.org/jira/browse/WW-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706737#comment-13706737 ] 

ASF subversion and git services commented on WW-4122:
-----------------------------------------------------

Commit 1502449 from [~lukaszlenart]
[ https://svn.apache.org/r1502449 ]

WW-4122 Improves loop
                
> Wasted work in AnnotationParameterFilterIntereptor.intercept()
> --------------------------------------------------------------
>
>                 Key: WW-4122
>                 URL: https://issues.apache.org/jira/browse/WW-4122
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.14.3
>         Environment: any
>            Reporter: Adrian Nistor
>              Labels: patch, performance
>             Fix For: 2.3.16
>
>         Attachments: patch.diff
>
>
> The problem appears in version 2.3.14.3 and in revision 1495522.  I
> attached a one-line patch that fixes it.  This problem and the
> attached patch are similar to the previously fixed WW-4115 and its
> patch.
> In method "AnnotationParameterFilterIntereptor.intercept", the loop
> over "annotatedFields" should break immediately after "allowed" is set
> to "true".  All the iterations after "allowed" is set to "true" do not
> perform any useful work, at best they just set "allowed" again to
> "true".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira