You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "hudeqi (via GitHub)" <gi...@apache.org> on 2023/05/05 02:26:32 UTC

[GitHub] [kafka] hudeqi commented on a diff in pull request #13617: MINOR:code optimization in QuorumController

hudeqi commented on code in PR #13617:
URL: https://github.com/apache/kafka/pull/13617#discussion_r1185653614


##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1635,7 +1636,7 @@ private enum ImbalanceSchedule {
     /**
      * Tracks if a snapshot generate was scheduled.
      */
-    private boolean generateSnapshotScheduled = false;
+    private final boolean generateSnapshotScheduled;

Review Comment:
   > If the value is always set to `false`, why have the variable at all? 🤔
   
   Hi, I also want to directly delete this variable because it has not been used anywhere, but I am not sure if this variable will be used in subsequent iteration development.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org