You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Thorsten Scherler <th...@apache.org> on 2005/09/07 10:40:36 UTC
Hardcoded values in forrest.xconf
On Wed, 2005-09-07 at 00:27 -0700, Diwaker Gupta wrote:
> Diff to make the internal plugin work
> -------------------------------------
>
> Index: webapp/WEB-INF/xconf/forrest-core.xconf
> ===================================================================
> --- webapp/WEB-INF/xconf/forrest-core.xconf (revision 279235)
> +++ webapp/WEB-INF/xconf/forrest-core.xconf (working copy)
> @@ -130,8 +130,10 @@
>
> <whiteboard-plugins-src>@forrest.home@/whiteboard/plugins</whiteboard-plugins-src>
> <plugins>@forrest.home@/build/plugins</plugins>
> <locationmap>@context.home@/locationmap.xml</locationmap>
> -
> <view-internal>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.view</view-internal>
> -
> <view-themes>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.view/resources/views</view-themes>
> +
> <view-internal>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.xhtml2</view-internal>
> +
> <view-themes>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.xhtml2/resources/views</view-themes>
> +
> <!--<view-internal>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.view</view-internal>-->
> +
> <!--<view-themes>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.view/resources/views</view-themes>-->
> <theme-ext>.fv</theme-ext>
> <theme>default</theme>
> </values>
>
I did that hardcoding. Why not just add a new property to the
forrest.properties?
So instead of hardcoding it again, why not using something like:
<view-internal>@forrest.home@/build/plugins/@project.viewPlugin@</view-internal>
salu2
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
Re: Hardcoded values in forrest.xconf
Posted by Thorsten Scherler <th...@apache.org>.
On Wed, 2005-09-07 at 19:57 +1000, David Crossley wrote:
> Thorsten Scherler wrote:
> >
> > I did that hardcoding. Why not just add a new property to the
> > forrest.properties?
> >
> > So instead of hardcoding it again, why not using something like:
> > <view-internal>@forrest.home@/build/plugins/@project.viewPlugin@</view-internal>
>
> I recorded an issue for that during FT
> http://issues.apache.org/jira/browse/FOR-664
> in case we forgot to get back to it.
>
> Yes it should be easy to do as you say.
>
> Sorry i added to Jira rathe rthan cleaning it up :-)
>
Which is perfectly alright.
Sorry I have not seen that issue. I should have read *all* mails before
replying to some. ;-)
Sorry for the noise and thanks David for already adding it.
> -David
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
Re: Hardcoded values in forrest.xconf
Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
>
> I did that hardcoding. Why not just add a new property to the
> forrest.properties?
>
> So instead of hardcoding it again, why not using something like:
> <view-internal>@forrest.home@/build/plugins/@project.viewPlugin@</view-internal>
I recorded an issue for that during FT
http://issues.apache.org/jira/browse/FOR-664
in case we forgot to get back to it.
Yes it should be easy to do as you say.
Sorry i added to Jira rathe rthan cleaning it up :-)
-David