You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2023/10/23 20:23:57 UTC
Review Request 74694: RANGER-4478: Incorrect trie updates when processing deltas - Part 2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74694/
-----------------------------------------------------------
Review request for ranger, madhan and Madhan Neethiraj.
Bugs: RANGER-4478
https://issues.apache.org/jira/browse/RANGER-4478
Repository: ranger
Description
-------
This is a follow-up patch for RANGER-4478 (https://reviews.apache.org/r/74680/). This patch removes calls to undoSetup() during modification of the Trie object because, when the Trie object was copied from the Trie object for earlier version of policies/tags, the undoSetup() is called and calling it again will be unnecessary at best.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java 61b6a4357
Diff: https://reviews.apache.org/r/74694/diff/1/
Testing
-------
Compiled and ran unit tests successfully.
Tested with a long running cluster with a client updating Hive policies frequenty and Hive queries issued from a beeline client.
Thanks,
Abhay Kulkarni
Re: Review Request 74694: RANGER-4478: Incorrect trie updates when processing deltas - Part 2
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74694/#review225889
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 23, 2023, 8:23 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74694/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2023, 8:23 p.m.)
>
>
> Review request for ranger, madhan and Madhan Neethiraj.
>
>
> Bugs: RANGER-4478
> https://issues.apache.org/jira/browse/RANGER-4478
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This is a follow-up patch for RANGER-4478 (https://reviews.apache.org/r/74680/). This patch removes calls to undoSetup() during modification of the Trie object because, when the Trie object was copied from the Trie object for earlier version of policies/tags, the undoSetup() is called and calling it again will be unnecessary at best.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java 61b6a4357
>
>
> Diff: https://reviews.apache.org/r/74694/diff/1/
>
>
> Testing
> -------
>
> Compiled and ran unit tests successfully.
>
> Tested with a long running cluster with a client updating Hive policies frequenty and Hive queries issued from a beeline client.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>